Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp module build script to make it work for 5.15 on Ubuntu 20.04 #3212

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

saiarcot895
Copy link
Contributor

@saiarcot895 saiarcot895 commented Jul 2, 2024

What I did

The current version of the script does not work at all when the host kernel is Azure's 5.15 kernel on Ubuntu 20.04. It does seem to work with 5.11 and older.

Update the script to add support for building and loading the kernel modules for the 5.15 kernel, while keeping support for the non-HWE kernel.

In addition, use a separate updates/sonic directory for the kernel modules we compile, to make it clear they were compiled separately and don't come from the official kernel build packages.

Finally, add a warning if we're compiling a kernel module for a different version of the kernel than what is currently running.

This is a cherry-pick of sonic-net/sonic-swss-common#720

Why I did it

How I verified it

Details if related

saiarcot895 and others added 2 commits July 2, 2024 11:42
The current version of the script does not work at all when the host
kernel is Azure's 5.15 kernel on Ubuntu 20.04. It does seem to work with
the non-HWE kernel (version 5.4).

Update the script to add support for building and loading the kernel
modules for the 5.15 kernel, while keeping support for the non-HWE
kernel.

This is a cherry-pick of sonic-net/sonic-swss-common#720

Signed-off-by: Saikrishna Arcot <[email protected]>
@yxieca yxieca merged commit 43ac585 into sonic-net:master Jul 2, 2024
17 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-swss that referenced this pull request Jul 2, 2024
…onic-net#3212)

* Revamp module build script to make it work for 5.15 on Ubuntu 20.04

The current version of the script does not work at all when the host
kernel is Azure's 5.15 kernel on Ubuntu 20.04. It does seem to work with
the non-HWE kernel (version 5.4).

Update the script to add support for building and loading the kernel
modules for the 5.15 kernel, while keeping support for the non-HWE
kernel.

This is a cherry-pick of sonic-net/sonic-swss-common#720

Signed-off-by: Saikrishna Arcot <[email protected]>

* Remove libswsscommon dependencies from the script

Signed-off-by: Saikrishna Arcot <[email protected]>

---------

Signed-off-by: Saikrishna Arcot <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #3214

mssonicbld pushed a commit to mssonicbld/sonic-swss that referenced this pull request Jul 2, 2024
…onic-net#3212)

* Revamp module build script to make it work for 5.15 on Ubuntu 20.04

The current version of the script does not work at all when the host
kernel is Azure's 5.15 kernel on Ubuntu 20.04. It does seem to work with
the non-HWE kernel (version 5.4).

Update the script to add support for building and loading the kernel
modules for the 5.15 kernel, while keeping support for the non-HWE
kernel.

This is a cherry-pick of sonic-net/sonic-swss-common#720

Signed-off-by: Saikrishna Arcot <[email protected]>

* Remove libswsscommon dependencies from the script

Signed-off-by: Saikrishna Arcot <[email protected]>

---------

Signed-off-by: Saikrishna Arcot <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #3215

mssonicbld pushed a commit that referenced this pull request Jul 2, 2024
…3212)

* Revamp module build script to make it work for 5.15 on Ubuntu 20.04

The current version of the script does not work at all when the host
kernel is Azure's 5.15 kernel on Ubuntu 20.04. It does seem to work with
the non-HWE kernel (version 5.4).

Update the script to add support for building and loading the kernel
modules for the 5.15 kernel, while keeping support for the non-HWE
kernel.

This is a cherry-pick of sonic-net/sonic-swss-common#720

Signed-off-by: Saikrishna Arcot <[email protected]>

* Remove libswsscommon dependencies from the script

Signed-off-by: Saikrishna Arcot <[email protected]>

---------

Signed-off-by: Saikrishna Arcot <[email protected]>
@saiarcot895 saiarcot895 deleted the revamp-module-build-script branch July 3, 2024 00:39
@mssonicbld
Copy link
Collaborator

@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!!
#3214

2 similar comments
@mssonicbld
Copy link
Collaborator

@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!!
#3214

@mssonicbld
Copy link
Collaborator

@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!!
#3214

yejianquan pushed a commit to yejianquan/sonic-swss that referenced this pull request Jul 8, 2024
…onic-net#3212)

* Revamp module build script to make it work for 5.15 on Ubuntu 20.04

The current version of the script does not work at all when the host
kernel is Azure's 5.15 kernel on Ubuntu 20.04. It does seem to work with
the non-HWE kernel (version 5.4).

Update the script to add support for building and loading the kernel
modules for the 5.15 kernel, while keeping support for the non-HWE
kernel.

This is a cherry-pick of sonic-net/sonic-swss-common#720

Signed-off-by: Saikrishna Arcot <[email protected]>

* Remove libswsscommon dependencies from the script

Signed-off-by: Saikrishna Arcot <[email protected]>

---------

Signed-off-by: Saikrishna Arcot <[email protected]>
@mssonicbld
Copy link
Collaborator

@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!!
#3214

@mssonicbld
Copy link
Collaborator

@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!!
#3214

1 similar comment
@mssonicbld
Copy link
Collaborator

@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!!
#3214

yejianquan added a commit to yejianquan/sonic-swss that referenced this pull request Jul 11, 2024
@mssonicbld
Copy link
Collaborator

@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!!
#3214

mssonicbld pushed a commit that referenced this pull request Jul 12, 2024
…3212)

* Revamp module build script to make it work for 5.15 on Ubuntu 20.04

The current version of the script does not work at all when the host
kernel is Azure's 5.15 kernel on Ubuntu 20.04. It does seem to work with
the non-HWE kernel (version 5.4).

Update the script to add support for building and loading the kernel
modules for the 5.15 kernel, while keeping support for the non-HWE
kernel.

This is a cherry-pick of sonic-net/sonic-swss-common#720

Signed-off-by: Saikrishna Arcot <[email protected]>

* Remove libswsscommon dependencies from the script

Signed-off-by: Saikrishna Arcot <[email protected]>

---------

Signed-off-by: Saikrishna Arcot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants