Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202305][ppi]: Implement port bulk comparison logic #2921

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Oct 6, 2023

Signed-off-by: Nazarii Hnydyn [email protected]

DEPENDS:

  1. [ppi]: Enable bulk API sonic-sairedis#1171
  2. [syncd]: Enable port bulk API sonic-sairedis#1197
  3. [subinterface] Fix admin state handling #2806

HLD: sonic-net/SONiC#1084

What I did

  • Implemented port bulk add/remove comparison logic
  • Refactored Port OA to facilitate port config operations

Why I did it

  • To improve switch Fast Boot startup time

How I verified it

  • UT tests
  • VS tests

Details if related

@nazariig
Copy link
Collaborator Author

nazariig commented Oct 9, 2023

@StormLiangMS / @prsunny can you please help to merge?

@prsunny
Copy link
Collaborator

prsunny commented Oct 10, 2023

@prgeor, is this approved for 202305? If so, please signoff and @StormLiangMS can take next steps. @nazariig , please confirm if its tested on 202305 as its mostly stabilized and this seems to be a big feature backport.

@StormLiangMS
Copy link
Contributor

This one is a new feature and get merged to master after 202305 branch out, would not pick up for 202305 and old ones, unless enough justification.

@prsunny @prgeor @nazariig

@liat-grozovik
Copy link
Collaborator

@StormLiangMS this is not correct. the entire feature is already in 202305 but this last one. it is already on 202211_1
this is not a new feature, this is a must feature that was not fully cherrypicked.

please take it to 202305

@StormLiangMS
Copy link
Contributor

@liat-grozovik got it, could I ask a full regress test with 202305 for this PR? Pls update the test result in the PR. @nazariig

@StormLiangMS
Copy link
Contributor

must to have for fast reboot, cherry pick to 202305.

@StormLiangMS StormLiangMS merged commit fc63383 into sonic-net:202305 Oct 11, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants