Remove counters for Mux ACL #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingwang-ms
approved these changes
Jan 26, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@bingwang-ms could we please re-run checks here? This has already been merged into 202205 and would like to be there in master as well. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kevinskwang
approved these changes
Mar 31, 2023
yxieca
added
Request for 202111 Branch
and removed
Request for 202205 Branch
Request for 202211 Branch
labels
|
#1982 was only committed to master branch. @StormLiangMS please check if it was included in 202211 branch. From merge time of #1982, it might have been included in 202211 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Do not use counters for mux ACL
Why I did it
Noticed that with PR #1982 counters are enabled by default. It was not the case earlier.
User won't be able to see it with
aclshowand it will waste valuable hardware counter resource.How I verified it
Details if related