Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202205] Fixed set mtu for deleted subintf due to late notification #2595

Merged

Conversation

dprital
Copy link
Collaborator

@dprital dprital commented Jan 1, 2023

PR against 202205 based on the following PR: #2571

What I did

Ignores errors on the set MTU command for subinterface when the subinterface state is not OK.

Why I did it

A race condition between the portmgrd and the intfmgrd sometimes causes running a set MTU command on a deleted subinterface.
The logs and the error:

INFO swss#supervisord: intfmgrd Cannot find device "Ethernet32.58"
ERR swss#intfmgrd: :- main: Runtime error: /sbin/ip link set "Ethernet32.58" mtu "9100" :
INFO swss#supervisord 2022-11-08 05:53:33,057 INFO exited: intfmgrd (exit status 255; not expected)

How I verified it

Run the test_loopback_action_reload test and saw no errors in the logs.

Details if related

@dprital dprital requested a review from prsunny as a code owner January 1, 2023 09:37
@bingwang-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original PR on master approved by prsunny. moving a head with this PR approval as well

@liat-grozovik liat-grozovik merged commit 8c9092c into sonic-net:202205 Jan 3, 2023
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Jan 3, 2023
Update sonic-swss submodule pointer to include the following:
* fb68ca8 [202205] [ACL] dereg acl-rule counters during acl-table del (sonic-net#2574) ([sonic-net#2582](sonic-net/sonic-swss#2582))
* 8c9092c [202205] Fixed set mtu for deleted subintf due to late notification ([sonic-net#2595](sonic-net/sonic-swss#2595))

Signed-off-by: dprital <[email protected]>
liat-grozovik pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Jan 4, 2023
* [202205][submodule] Advance sonic-swss pointer
Update sonic-swss submodule pointer to include the following:
* fb68ca8 [202205] [ACL] dereg acl-rule counters during acl-table del (#2574) ([#2582](sonic-net/sonic-swss#2582))
* 8c9092c [202205] Fixed set mtu for deleted subintf due to late notification ([#2595](sonic-net/sonic-swss#2595))

Signed-off-by: dprital <[email protected]>
@dprital dprital deleted the fix_set_mtu_for_delted_subinf_202205 branch March 7, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants