Support for tc-dot1p and tc-dscp qosmap #2559

dmukun · 2022-12-06T09:39:34Z

What I did

Added support to configure TC-DOT1P qos map
Added support to attach TC-DOT1P qos map to interface
Added support to attach TC-DSCP qos map to interface
Modified print strings in qos map handler functions

Note: All of the above are configured via json

Why I did it
Repo code does not contain support to configure TC-DOT1P qos map or support to attach TC-DSCP qos map to interface. There is partial support to configure TC-DSCP qos map

How I verified it
Sample configuration

{
"TC_TO_DOT1P_MAP": {
        "MAP1": {
            "0" : "3",
            "1" : "3",
            "2" : "1",
            "3" : "3",
            "4" : "4",
            "5" : "2",
            "6" : "1",
            "7" : "1"
        }
},
"TC_TO_DSCP_MAP": {
        "MAP1": {
            "0" : "3",
            "1" : "23",
            "2" : "11",
            "3" : "31",
            "4" : "44",
            "5" : "23",
            "6" : "19",
            "7" : "1"
        }
},

"PORT_QOS_MAP": {
        "Ethernet12": {
            "tc_to_dscp_map"  : "MAP1",
            "tc_to_dot1p_map"  : "MAP1"
         }
    }
}

Verified that L2 traffic with incoming dot1p priority is appropriatly remarked on outgoing interface (on which qos map is attached)
Verified that IP DSCP field is remarked appropriately as per configuration
Verified syslog, swss and sairedis.rec logs

Details if related
This commit has dependency on swss-common repo commit.
sonic-net/sonic-swss-common#721

Which release branch to backport (provide reason below if selected)

linux-foundation-easycla · 2022-12-06T09:39:37Z

The committers listed above are authorized under a signed CLA.

✅ login: dmukun / name: Divya Mukundan (c2d1301)

jarias-lfx · 2022-12-08T14:34:12Z

/easycla

dmukun · 2022-12-08T14:49:12Z

Note that build failure is expected as this PR is dependent on this sonic-swss-common PR which should be approved and merged first.

…into tc-dot1p-qosmap

bingwang-ms · 2022-12-16T01:51:22Z

/azp run

azure-pipelines · 2022-12-16T01:51:32Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2022-12-19T18:09:07Z

/azp run

azure-pipelines · 2022-12-19T18:09:18Z

Azure Pipelines successfully started running 1 pipeline(s).

dmukun · 2023-01-05T06:00:33Z

/azp run

azure-pipelines · 2023-01-05T06:00:38Z

Commenter does not have sufficient privileges for PR 2559 in repo sonic-net/sonic-swss

prsunny · 2023-01-05T16:15:31Z

/azp run

azure-pipelines · 2023-01-05T16:15:42Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2023-01-06T02:11:16Z

@dmukun , please add unit tests to meet the coverage requirements

…into tc-dot1p-qosmap

dmukun · 2023-01-18T07:05:05Z

/azpw run

mssonicbld · 2023-01-18T07:05:07Z

/AzurePipelines run

azure-pipelines · 2023-01-18T07:05:17Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2023-01-23T17:56:04Z

@neethajohn , could you please review/signoff?

dmukun · 2023-01-30T06:31:53Z

@neethajohn Can you review this and enable commit, please?

dmukun · 2023-02-07T14:08:29Z

@neethajohn Can you complete this review, please?

prsunny · 2023-02-10T16:34:34Z

@bingwang-ms , could you please review this?

bingwang-ms · 2023-02-17T18:13:57Z

Sorry for the delay. The change looks good to me. Thanks for correction in the log message! @dmukun

dmukun · 2023-02-20T05:43:09Z

Thank you, @prsunny @bingwang-ms

* Support for tc-dot1p and tc-dscp qosmap

Update sonic-swss submodule pointer to include the following: * f66abed Support for tc-dot1p and tc-dscp qosmap ([sonic-net#2559](sonic-net/sonic-swss#2559)) * 35385ad [RouteOrch] Record ROUTE_TABLE entry programming status to APPL_STATE_DB ([sonic-net#2512](sonic-net/sonic-swss#2512)) * 0704f78 [Workaround] EvpnRemoteVnip2pOrch warmboot check failure ([sonic-net#2626](sonic-net/sonic-swss#2626)) * 4df5cab [ResponsePublisher] add pipeline support ([sonic-net#2511](sonic-net/sonic-swss#2511)) Signed-off-by: AntonHryshchuk <[email protected]>

Update sonic-swss submodule pointer to include the following: * baa302e Do not allow to add port to .1Q bridge while router port deletion is not completed ([sonic-net#2669](sonic-net/sonic-swss#2669)) * f66abed Support for tc-dot1p and tc-dscp qosmap ([sonic-net#2559](sonic-net/sonic-swss#2559)) * 35385ad [RouteOrch] Record ROUTE_TABLE entry programming status to APPL_STATE_DB ([sonic-net#2512](sonic-net/sonic-swss#2512)) * 0704f78 [Workaround] EvpnRemoteVnip2pOrch warmboot check failure ([sonic-net#2626](sonic-net/sonic-swss#2626)) * 4df5cab [ResponsePublisher] add pipeline support ([sonic-net#2511](sonic-net/sonic-swss#2511)) Signed-off-by: dprital <[email protected]>

Update sonic-swss submodule pointer to include the following: * baa302e Do not allow to add port to .1Q bridge while router port deletion is not completed ([#2669](sonic-net/sonic-swss#2669)) * f66abed Support for tc-dot1p and tc-dscp qosmap ([#2559](sonic-net/sonic-swss#2559)) * 35385ad [RouteOrch] Record ROUTE_TABLE entry programming status to APPL_STATE_DB ([#2512](sonic-net/sonic-swss#2512)) * 0704f78 [Workaround] EvpnRemoteVnip2pOrch warmboot check failure ([#2626](sonic-net/sonic-swss#2626)) * 4df5cab [ResponsePublisher] add pipeline support ([#2511](sonic-net/sonic-swss#2511))

* Support for tc-dot1p and tc-dscp qosmap

Support for tc-dot1p and tc-dscp qosmap

c2d1301

dmukun requested review from neethajohn and prsunny as code owners December 6, 2022 09:39

dmukun mentioned this pull request Dec 6, 2022

Support for TC-DOT1p qos map sonic-net/sonic-swss-common#721

Merged

8 tasks

dmukun added 2 commits December 15, 2022 09:28

Support for tc-dot1p and tc-dscp qosmap

dabf819

Merge branch 'tc-dot1p-qosmap' of https://github.com/dmukun/sonic-swss …

d031854

…into tc-dot1p-qosmap

Merge branch 'sonic-net:master' into tc-dot1p-qosmap

099d119

dmukun mentioned this pull request Jan 3, 2023

Updating submodule (swss-common) after PR#721 commit sonic-net/sonic-buildimage#13144

Merged

8 tasks

dmukun added 2 commits January 13, 2023 17:59

Merge branch 'tc-dot1p-qosmap' of https://github.com/dmukun/sonic-swss …

a6160da

…into tc-dot1p-qosmap

Merge branch 'tc-dot1p-qosmap' of https://github.com/dmukun/sonic-swss …

6ee13fd

…into tc-dot1p-qosmap

Merge branch 'sonic-net:master' into tc-dot1p-qosmap

2be8261

prsunny requested a review from bingwang-ms February 10, 2023 16:34

bingwang-ms approved these changes Feb 17, 2023

View reviewed changes

prsunny merged commit f66abed into sonic-net:master Feb 20, 2023

prsunny added Request for 202111 Branch Request for 202205 Branch Request for 202211 Branch and removed Request for 202111 Branch labels Feb 20, 2023

yxieca pushed a commit that referenced this pull request Feb 21, 2023

Support for tc-dot1p and tc-dscp qosmap (#2559)

380f72b

* Support for tc-dot1p and tc-dscp qosmap

yxieca added the Included in 202205 Branch label Feb 21, 2023

dprital mentioned this pull request Feb 23, 2023

[submodule] Advance sonic-swss pointer sonic-net/sonic-buildimage#13953

Merged

8 tasks

StormLiangMS pushed a commit that referenced this pull request Mar 7, 2023

Support for tc-dot1p and tc-dscp qosmap (#2559)

53ee0a8

* Support for tc-dot1p and tc-dscp qosmap

StormLiangMS added the Included in 202211 Branch label Mar 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for tc-dot1p and tc-dscp qosmap #2559

Support for tc-dot1p and tc-dscp qosmap #2559

dmukun commented Dec 6, 2022 •

edited

Loading

linux-foundation-easycla bot commented Dec 6, 2022 •

edited

Loading

jarias-lfx commented Dec 8, 2022

dmukun commented Dec 8, 2022 •

edited

Loading

bingwang-ms commented Dec 16, 2022

azure-pipelines bot commented Dec 16, 2022

prsunny commented Dec 19, 2022

azure-pipelines bot commented Dec 19, 2022

dmukun commented Jan 5, 2023

azure-pipelines bot commented Jan 5, 2023

prsunny commented Jan 5, 2023

azure-pipelines bot commented Jan 5, 2023

prsunny commented Jan 6, 2023

dmukun commented Jan 18, 2023

mssonicbld commented Jan 18, 2023

azure-pipelines bot commented Jan 18, 2023

prsunny commented Jan 23, 2023

dmukun commented Jan 30, 2023

dmukun commented Feb 7, 2023

prsunny commented Feb 10, 2023

bingwang-ms commented Feb 17, 2023 •

edited

Loading

dmukun commented Feb 20, 2023

Support for tc-dot1p and tc-dscp qosmap #2559

Support for tc-dot1p and tc-dscp qosmap #2559

Conversation

dmukun commented Dec 6, 2022 • edited Loading

Which release branch to backport (provide reason below if selected)

linux-foundation-easycla bot commented Dec 6, 2022 • edited Loading

jarias-lfx commented Dec 8, 2022

dmukun commented Dec 8, 2022 • edited Loading

bingwang-ms commented Dec 16, 2022

azure-pipelines bot commented Dec 16, 2022

prsunny commented Dec 19, 2022

azure-pipelines bot commented Dec 19, 2022

dmukun commented Jan 5, 2023

azure-pipelines bot commented Jan 5, 2023

prsunny commented Jan 5, 2023

azure-pipelines bot commented Jan 5, 2023

prsunny commented Jan 6, 2023

dmukun commented Jan 18, 2023

mssonicbld commented Jan 18, 2023

azure-pipelines bot commented Jan 18, 2023

prsunny commented Jan 23, 2023

dmukun commented Jan 30, 2023

dmukun commented Feb 7, 2023

prsunny commented Feb 10, 2023

bingwang-ms commented Feb 17, 2023 • edited Loading

dmukun commented Feb 20, 2023

dmukun commented Dec 6, 2022 •

edited

Loading

linux-foundation-easycla bot commented Dec 6, 2022 •

edited

Loading

dmukun commented Dec 8, 2022 •

edited

Loading

bingwang-ms commented Feb 17, 2023 •

edited

Loading