[ACL] Support ACTION_COUNTER action in custom ACL table type #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bingwang <[email protected]>
6 tasks
|
@stepanblyschak Can you please help review? |
stepanblyschak
approved these changes
Nov 30, 2022
prsunny
approved these changes
Dec 2, 2022
yxieca
pushed a commit
that referenced
this pull request
Dec 7, 2022
* Support COUNTER action in custom ACL Signed-off-by: bingwang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR is to update aclorch to support
SAI_ACL_ENTRY_ATTR_ACTION_COUNTERaction in custom ACL table type.Before this change, ACL counter is not supported in custom ACL type.
Why I did it
Because we need the custom ACL type with counter supported.
How I verified it
Verified by building a new image, and check the counter.
Details if related