Add support for voq counters in portsorch. #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skbarista , i see the subport tests are consistently failing for this PR but not for others. Please make sure, it is passing consistently test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_creation FAILED |
vmittal-msft
previously approved these changes
Oct 6, 2022
* Add m_voq_ids to SystemPortInfo to maintain the list of queue ids. * Add two new tables COUNTERS_SYSTEM_PORT_NAME_MAP and COUNTERS_VOQ_NAME_MAP to enable queuestat to differentiate between Port Tx queues and Voqs. * Add a new function initializeVoqs that retrieves the number of voqs for a system port and stores the voq object ids in m_voq_ids * Add code to handle queue type SAI_QUEUE_TYPE_UNICAST_VOQ. * Initialize voqs and populate COUNTERS_SYSTEM_PORT_NAME_MAP in addSystemPorts function. * Update generateQueueMap to generate queue maps for both Txqs and Voq. For PHY ports in a voq system both Txqs and Voqs are instantiated. For Voqs of remote system port, only Voq counters are initialized.
vmittal-msft
previously approved these changes
Oct 6, 2022
* Add m_voq_ids to SystemPortInfo to maintain the list of queue ids. * Add two new tables COUNTERS_SYSTEM_PORT_NAME_MAP and COUNTERS_VOQ_NAME_MAP to enable queuestat to differentiate between Port Tx queues and Voqs. * Add a new function initializeVoqs that retrieves the number of voqs for a system port and stores the voq object ids in m_voq_ids * Add code to handle queue type SAI_QUEUE_TYPE_UNICAST_VOQ. * Initialize voqs and populate COUNTERS_SYSTEM_PORT_NAME_MAP in addSystemPorts function. * Update generateQueueMap to generate queue maps for both Txqs and Voq. For PHY ports in a voq system both Txqs and Voqs are instantiated. For Voqs of remote system port, only Voq counters are initialized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Add m_voq_ids to SystemPortInfo to maintain the list of queue ids. * Add two new tables COUNTERS_SYSTEM_PORT_NAME_MAP and COUNTERS_VOQ_NAME_MAP to enable queuestat to differentiate between Port Tx queues and Voqs. * Add a new function initializeVoqs that retrieves the number of voqs for a system port and stores the voq object ids in m_voq_ids * Add code to handle queue type SAI_QUEUE_TYPE_UNICAST_VOQ. * Initialize voqs and populate COUNTERS_SYSTEM_PORT_NAME_MAP in addSystemPorts function. * Update generateQueueMap to generate queue maps for both Txqs and Voq. For PHY ports in a voq system both Txqs and Voqs are instantiated. For Voqs of remote system port, only Voq counters are initialized.
* Add m_voq_ids to SystemPortInfo to maintain the list of queue ids. * Add two new tables COUNTERS_SYSTEM_PORT_NAME_MAP and COUNTERS_VOQ_NAME_MAP to enable queuestat to differentiate between Port Tx queues and Voqs. * Add a new function initializeVoqs that retrieves the number of voqs for a system port and stores the voq object ids in m_voq_ids * Add code to handle queue type SAI_QUEUE_TYPE_UNICAST_VOQ. * Initialize voqs and populate COUNTERS_SYSTEM_PORT_NAME_MAP in addSystemPorts function. * Update generateQueueMap to generate queue maps for both Txqs and Voq. For PHY ports in a voq system both Txqs and Voqs are instantiated. For Voqs of remote system port, only Voq counters are initialized.
* Add m_voq_ids to SystemPortInfo to maintain the list of queue ids. * Add two new tables COUNTERS_SYSTEM_PORT_NAME_MAP and COUNTERS_VOQ_NAME_MAP to enable queuestat to differentiate between Port Tx queues and Voqs. * Add a new function initializeVoqs that retrieves the number of voqs for a system port and stores the voq object ids in m_voq_ids * Add code to handle queue type SAI_QUEUE_TYPE_UNICAST_VOQ. * Initialize voqs and populate COUNTERS_SYSTEM_PORT_NAME_MAP in addSystemPorts function. * Update generateQueueMap to generate queue maps for both Txqs and Voq. For PHY ports in a voq system both Txqs and Voqs are instantiated. For Voqs of remote system port, only Voq counters are initialized.
vmittal-msft
approved these changes
Oct 12, 2022
7 tasks
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Nov 10, 2022
Advance sonic-swss submodule to pick up new commits: dbdf31c [counters] Improve performance by polling only configured ports buffer queue/pg counters sonic-net/sonic-swss#2473 ab4f804 [portsorch] remove port OID from saiOidToAlias map on port deletion sonic-net/sonic-swss#2483 ab29920 [QoS] Support dynamic headroom calculation for Barefoot platforms sonic-net/sonic-swss#2412 15beee4 Add support for voq counters in portsorch. sonic-net/sonic-swss#2467 c8d4905 [vlanmgr] Disable arp_evict_nocarrier for vlan host intf sonic-net/sonic-swss#2469 31c9321 [chassis][voq]Collect counters for fabric links sonic-net/sonic-swss#1944 Signed-off-by: Kebo Liu <[email protected]>
|
@skbarista this change cannot be cherry-picked cleanly. please create new PR for 202205 branch. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add m_voq_ids to SystemPortInfo to maintain the list of queue ids.
Add two new tables COUNTERS_SYSTEM_PORT_NAME_MAP and
COUNTERS_VOQ_NAME_MAP to enable queuestat to differentiate between
Port Tx queues and Voqs.
Add a new function initializeVoqs that retrieves the number of voqs
for a system port and stores the voq object ids in m_voq_ids
Add code to handle queue type SAI_QUEUE_TYPE_UNICAST_VOQ.
Initialize voqs and populate COUNTERS_SYSTEM_PORT_NAME_MAP in
addSystemPorts function.
Update generateQueueMap to generate queue maps for both Txqs and Voq.
For PHY ports in a voq system both Txqs and Voqs are instantiated. For
Voqs of remote system port, only Voq counters are initialized.
Why I did it
Add support for voq counters.
How I verified it
Modified queuestat locally and confirming the counters are populated for Voqs.
Details if related