Fix random failure in PR/CI build. #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
approved these changes
Nov 4, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liushilongbuaa
added a commit
to liushilongbuaa/sonic-swss
that referenced
this pull request
Dec 7, 2021
liushilongbuaa
added a commit
that referenced
this pull request
Dec 8, 2021
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…delete whole config move (sonic-net#2006) #### What I did Not generating delete whole config move because it is not allowed by JsonPatch library and it is not possible for ConfigDb to be equal to NULL. This solves the first problem in issue sonic-net/sonic-utilities#2000 (comment) #### How I did it - Verified UpperLevelMoveExtender does not generate delete whole config move - Modified DeleteInsteadOfReplaceMoveExtender to not generate delete whole config move - DeleteRefsMoveExtender cannot generate delete whole config move, because it deletes the referrer leafs #### How to verify it unit-test #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I add step to clean work space.
Thus avoid random failure in azure pipeline.
Why I did it
There are build failures because of work space not clean.
https://dev.azure.com/mssonic/build/_build/results?buildId=48551&view=logs&j=e51ebb60-45fa-5846-0822-3aaf597a9c80&t=29c82d13-0aa4-5ac7-9d6a-e34d59819a1b
How I verified it
Details if related