[routeorch]: Do not set packet action for updating next hop ID #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qiluo-msft , can you review? |
qiluo-msft
approved these changes
Apr 28, 2017
The current design set the SAI_ROUTE_ATTR_PACKET_ACTION to SAI_PACKET_ACTION_FORWARD every time the route is updated. This will generate double SET function calls. With this fix, the SAI_ROUTE_ATTR_PACKET_ACTION is only set to SAI_PACKET_ACTION_FORWARD when there was no next hop (dropped). Also update the default dropped routes to point to empty next hop object. Signed-off-by: Shuotian Cheng <[email protected]>
lguohan
approved these changes
Apr 28, 2017
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuotian Cheng [email protected]