[macsecmgr]: Add rekey period in macsec mgr #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ze Gan <[email protected]>
shyam77git
reviewed
Oct 19, 2021
| "macsec_rekey_period", | ||
| profile.rekey_period); | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this change sufficient for platform to take this change, modify 'rekey_period" to a desired value, do config reload and validate this rekey feature?
Rest all code (workflow) related to rekey in sonic (MACSecmgrd, wpa_supplicant etc.) already committed?
There was a problem hiding this comment.
Yes, please also update the wpa_supplicant. I have a PR: sonic-net/sonic-buildimage#8998 to update the wpa_supplicant submodule in sonic-buildimage
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Ze Gan <[email protected]>
lguohan
approved these changes
Oct 26, 2021
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Add explicit sections for showing management/loopback interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ze Gan [email protected]
What I did
Expose mka rekey option to config db
Why I did it
This feature is needed
How I verified it
Run
The SAK should be proactively refresh about 10 seconds
Details if related