[201911][Cherry-pick] [acl mirror action] Mirror session ref count fix at acl rule attachment #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bingwang <[email protected]>
bingwang-ms
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wendani
reviewed
Sep 3, 2021
tests/test_mirror.py
Outdated
Comment on lines
900
to
903
| # Add Dummy always-pass test at end as workaroud | ||
| # for issue when Flaky fail on final test it invokes module tear-down before retrying | ||
| def test_nonflaky_dummy(): | ||
| pass |
There was a problem hiding this comment.
This section is not needed for 201911 vs test. But it does not matter if vs test is not run for 201911.
There was a problem hiding this comment.
Thanks. Why didn't we need this patch for 201911?
Signed-off-by: bingwang <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Sep 3, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
… table (sonic-net#1896) * [acl-loader] modify acl-loader with change in STATE DB ACL capability table Signed-off-by: Stepan Blyshchak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bingwang [email protected]
What I did
This PR is a cherry-pick of #1761 from master branch to 201911 branch.
I have to create another PR to pick up the code since it's not a cleanup cherry-pick. Conflicts exist in UT code.
This PR will fix #1891 as well.
Why I did it
Please see #1761.
How I verified it
Details if related