Remove buffer drop counter when port is deleted

[tomer-israel]

Signed-off-by: tomeri [email protected]

What I did
I added the removal of port buffer drop counter on the deinit port flow.
it was added to the deInitPort function.

Why I did it
the buffer drop counter was never removed when port was deleted.
this flex counter was create on the initPort function but it was removed when the port was deleted

How I verified it
removed and created a port and check the FLEX_COUNTER redis table

FLEX_COUNTER_TABLE:PORT_BUFFER_DROP_STAT table

Details if related

[tomer-israel]

/azpw run

[tomer-israel]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 1860 in repo Azure/sonic-swss

[tomer-israel]

i have these failures on the swss checkers:

• test_zero_cable_len_profile_update
• test_route_nhg
• test_route_nhg_exhaust
• test_SpeedAndBufferSet

vs tests:
test_SpeedAndBufferSet failed (1 runs remaining out of 2).
<class 'AssertionError'>
Unexpected number of keys: expected=4, received=3 (('egress_lossy_profile', 'egress_lossless_profile', 'ingress_lossy_profile')), table="BUFFER_PROFILE"
[<TracebackEntry /home/vsts/work/1/s/tests/test_speed.py:39>, <TracebackEntry /home/vsts/work/1/s/tests/dvslib/dvs_database.py:366>]
test_SpeedAndBufferSet failed; it passed 0 out of the required 1 times.
<class 'AssertionError'>
Unexpected number of keys: expected=4, received=3 (('egress_lossy_profile', 'egress_lossless_profile', 'ingress_lossy_profile')), table="BUFFER_PROFILE"
[<TracebackEntry /home/vsts/work/1/s/tests/test_speed.py:39>, <TracebackEntry /home/vsts/work/1/s/tests/dvslib/dvs_database.py:366>]

it looks not related to my change and I also saw the same errors on this PR (the PR is not related to our PR):
#1861

so maybe we need to rerun these tests
@prsunny

[liat-grozovik]

@stephenxs could you pls help to review?

[liat-grozovik]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[tomer-israel]

the errors on the checkers are not related to my change at all, the test is checking number of routes in the system:

test_PerfAddRemoveRoute failed (1 runs remaining out of 2).
	<class 'AssertionError'>
	Unexpected number of keys: expected=10007, received=10008 (('{"dest":"100.9.7.0/24","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000022"}', '{"dest":"100.28.67.0/24","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000022"}', 
...
'{"dest":"100.27.48.0/24","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000022"}')), table="ASIC_STATE:SAI_OBJECT_TYPE_ROUTE_ENTRY"
	[<TracebackEntry /home/vsts/work/1/s/tests/test_route.py:949>, <TracebackEntry /home/vsts/work/1/s/tests/dvslib/dvs_database.py:366>]

[neethajohn]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[neethajohn]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[neethajohn]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[liat-grozovik]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[tomer-israel]

the checkers were failed due to:
"[2021-09-12 13:11:15] [build-stderr] main.cpp:2:10: fatal error: sai.h: No such file or directory"

this error is not related to code change.

please rerun the checkers

[tomer-israel]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[liat-grozovik]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[tomer-israel]

/azpw run

[tomer-israel]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 1860 in repo Azure/sonic-swss

[tomer-israel]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[qiluo-msft]

Just retriggered LGTM analysis: C/C++.

[tomer-israel]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[tomer-israel]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[tomer-israel]

failures not related to this change - rerun

/azpw run

[tomer-israel]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[tomer-israel]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[liat-grozovik]

@neethajohn and @stephenxs could you please help to review?