[intfmgrd] reach reconciled state at start when there are no interfaces configuration to process #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
|
@srj102 , @tapashdas , @nkelapur to review |
nkelapur
reviewed
Apr 6, 2021
cfgmgr/intfmgr.cpp
Outdated
| m_cfgLagIntfTable.getKeys(intfList); | ||
| std::copy( intfList.begin(), intfList.end(), std::inserter( m_pendingReplayIntfList, m_pendingReplayIntfList.end() ) ); | ||
|
|
||
| SWSS_LOG_INFO("Found %d Total Intfs to be replayed", (int)m_pendingReplayIntfList.size() ); | ||
| } | ||
|
|
||
| void IntfMgr::setWarmReplayDoneState() | ||
| { | ||
| replayDone = true; |
There was a problem hiding this comment.
please follow the class member naming convention now that "replayDone" is a member variable.
Signed-off-by: Stepan Blyschak <[email protected]>
|
@stepanblyschak , @nkelapur , this is required for 202012 branch, correct? |
Yes, this should be required for passing the sanity tests as mentioned by Stepan. However as I understand, in practical usage there will not be a scenario where there are no interfaces in the system, and hence the reported issue should not occur. |
prsunny
approved these changes
Apr 7, 2021
|
@daall - Can you please merge to 202012 ? |
|
@volodymyrsamotiy please create PR for 202012 branch as this change cannot be cherry-picked cleanly. |
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…es configuration to process (sonic-net#1695) * fix intfmgrd reconciliation when there are no interfaces in the system Signed-off-by: Stepan Blyschak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak [email protected]
What I did
If there is no pending configuration intfmgrd should reach reconciled state immediately. Same does for example vlanmgrd.
Why I did it
fdbsyncd waits till intfmgrd reaches reconciled state otherwise exits with exception about timeout. As a result sanity checkers complain about that.
How I verified it
I tested it on the switch by running warm-reboot and observed no fdbsyncd failure.
Also I wrote a simple test for intfmgrd warm restart when there are no interfaces in config_db.
Details if related