[Dynamic Buffer Calc] Enhancement: coding style and LGTM alerts #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add one space between "//" and the comments Use capital letter at the beginning of sentence refreshPriorityGroupsForPort => refreshPgsForPort Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
|
This pull request fixes 10 alerts when merging 5ca47bf into 637e8d0 - view on LGTM.com fixed alerts:
|
liat-grozovik
approved these changes
Apr 6, 2021
neethajohn
approved these changes
Apr 6, 2021
yxieca
pushed a commit
that referenced
this pull request
Apr 8, 2021
* Improve coding styles - Add one space between "//" and the comments - Use capital letter at the beginning of sentence - refreshPriorityGroupsForPort => refreshPgsForPort * Fix LGTM alerts Signed-off-by: Stephen Sun <[email protected]>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…c-net#1693) * Improve coding styles - Add one space between "//" and the comments - Use capital letter at the beginning of sentence - refreshPriorityGroupsForPort => refreshPgsForPort * Fix LGTM alerts Signed-off-by: Stephen Sun <[email protected]>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
When run "make modules_prepare", it prompts an ask as below: Microsoft Network Devices (NET_VENDOR_MICROSOFT) [Y/n/?] (NEW) It should be caused by the new version of the kernel config mis-match with existing one. To fix it, add the CONFIG_NET_VENDOR_MICROSOFT and CONFIG_MICROSOFT_MANA settings in the .config file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
How I verified it
Run regression and vs test
Details if related
//and the commentsrefreshPriorityGroupsForPort=>refreshPgsForPort