[vstest] VOQ system lag vs test timing issue fix #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to fix system lag test failure issue reported by issues sonic-net#1687. Fixed time sleep after creating and deleting system lag is replaced by DVS's wait_for_n_keys() functions Signed-off-by: vedganes <[email protected]>
lguohan
approved these changes
Apr 9, 2021
|
thank you. |
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
Changes to fix system lag test failure issue reported by issues sonic-net#1687. Fixed time sleep after creating and deleting system lag is replaced by DVS's wait_for_n_keys() functions Signed-off-by: vedganes <[email protected]>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Signed-off-by: pettershao-ragilenetworks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
In Virtual chassis test suite, time sleep for 1 second after creating and deleting system lag is replaced by
DVS's wait_for_n_keys() function.
Why I did it
Potential fix for issue #1687.
How I verified it
Ran pytest on docker sonic vs image multiple times with this fix. 100% pass.
Details if related