sonic-swss changes for MPLS #1686

qbdwlr · 2021-03-31T19:14:36Z

What I did
SONiC swss support for MPLS:

RouteOrch support for SAI MPLS inseg
NeighOrch support for MPLS NHs.
CrmOrch support for MPLS inseg and NH accounting.
New sonic-swss/tests/test_mpls.py for verification.

Why I did it
SONiC swss support for MPLS

How I verified it
Unit-tests in sonic-swss/tests/test_mpls.py and sonic-utilities/tests
System tests in sonic-mgmt

Details if related
Refer to HLD: sonic-net/SONiC#706

orchagent/crmorch.cpp

fpmsyncd/routesync.cpp

prsunny · 2021-04-08T21:03:43Z

orchagent/intfsorch.cpp

@@ -1042,6 +1076,10 @@ bool IntfsOrch::addRouterIntfs(sai_object_id_t vrf_id, Port &port)
    attr.value.u32 = port.m_mtu;
    attrs.push_back(attr);

+    attr.id = SAI_ROUTER_INTERFACE_ATTR_ADMIN_MPLS_STATE;


Should we check if mpls is supported similar to NAT below?

@prsunny IntfsOrch::addRouterIntfs() has been updated to only include SAI_ROUTER_INTERFACE_ATTR_ADMIN_MPLS_STATE if non-default (ie, enable) is configured. Explicit configuration to enable MPLS presumes platform that supports MPLS. MPLS attr is no longer set on platforms unless it is explicitly part of the configuration.

I'm puzzled that what the rif type SAI_ROUTER_INTERFACE_TYPE_MPLS_ROUTER is used for ? I didn't find it in current SWSS code. @qbdwlr

orchagent/neighorch.cpp

prsunny · 2021-04-08T21:13:02Z

orchagent/neighorch.cpp

-
-        if (status != SAI_STATUS_ITEM_NOT_FOUND)
+        /* If we can't remove the next hop, return false. */
+        if (!removeNextHop(nexthop))


The flow is slightly changed here. Previously we remove this nexthop from the map only after neighbor is successfully removed. What is the motivation?

@TACappleman Tom made these changes and can address your question.

The main part of this change is to move the actual deletion of the next hop over the SAI into the removeNextHop (so that when e.g. routeorch calls this method it does what you'd expect it to). It then makes sense for the deletion of the next hop from the map to happen at the point that it no longer exists on the SAI, and so the small functional change as a result of this set of changes seems reasonable. (Otherwise you could delete the next hop and fail to delete the neighbor, and so not record that the next hop has been deleted).

Please change it to original flow and have only the changes for mpls addition. Else its difficult to understand what is optimized here.

@prsunny You need to re-examine the original code. You will see there is NextHop clean-up code in ::removeNeighbor instead of in ::removeNextHop. This only worked because for IP there is a 1-1 mapping between NextHop and Neighbor, so the NextHop was only removed when the Neighbor was also being removed. With MPLS NHs, this is no longer true. Now there is n-1 mapping between NH and Neighbor, so NextHop cleanup must occur within the context of ::removeNextHop to ascertain that NH is truly cleaned up. ::removeNeighbor can (and does) call :;removeNextHop to achieve its previous functionality.

previous flow was

SAI Remove nexthop 2. SAI remove neighbor 3. Neighbor map remove 4. Nexthop Map remove

new flow:

SAI Remove nexthop 2 Nexthop Map remove 3. SAI remove neighbor 4. Neighbor map remove

How does mpls n-1:1 mapping between nh and neighbor cover new flow ?

@abdosi With MPLS NHs, you can no longer assume that Neighbor is removed when NextHop is removed. I am puzzled as to why this flow does not remove Neighbor/Nexthop in the reverse order that Neighbor/Nexthop is created. Can you explain why addNextHop() has SAI API calls, but removeNextHop() does not? There seems to be some (possible unintentional) asymmetry here that needs to be explained.

There are assumptions made on the existence of NH map if Neighbor is failed to remove. I'm unable to understand what is the n:1 relation here. If there is mpls specific nh that is not related to neighbor, it should be in a different function

@prsunny Per the discussion, I have reverted NeighOrch::removeNextHop and added separate NeighOrch::removeMplsNextHop.

prsunny · 2021-04-08T21:17:19Z

orchagent/routeorch.cpp

@@ -1951,3 +2005,767 @@ bool RouteOrch::removeOverlayNextHops(sai_object_id_t vrf_id, const NextHopGroup
    return true;
 }

+void RouteOrch::doLabelTask(Consumer& consumer)


This is considerable code to routeorch. Suggest moving to a different file mplsrouteorch.cpp, @abdosi ?

The functionality to process LABEL_ROUTE_TABLE and ROUTE_TABLE is almost identical in nature. Both process NH/NHG association with label or prefix. Moving to a separate file file implies that the functionality is inherently different, which isn't true.

I agree but at the same time why do you need a separate task for label route? Other than SAI API what is different.

I have moved the MPLS related functions into a separate file: routeorch_mpls.cpp

lets not have _ in filename. Suggest follow existing naming for orch files and rename to mplsrouteorch.cpp

Still it doesn't mean we need to have a different new naming convention.

I still see this open. Please address this.

I have checked the file lengths in sonic-swss/orchagent and found that there are three other Orch components with file sizes larger than routeorch.cpp. Subdividing RouteOrch for file size reasons will not be done within the context of this PR.

Sorry, I dont prefer mpls changes to be present as part of routeorch.

@prsunny Done

orchagent/routeorch.cpp

lguohan · 2021-04-09T23:31:45Z

missing pytest

cfgmgr/intfmgr.cpp

fpmsyncd/routesync.cpp

smaheshm · 2021-04-13T00:19:49Z

Can you update in the description your code changes at high level.

lguohan

placeholder, we need to sonic-mgmt plan, otherwise, the feature cannot be tested end-to-end.

kperumalbfn · 2021-04-20T23:16:37Z

orchagent/neighorch.cpp

+        next_hop_attr.value.s32 = SAI_NEXT_HOP_TYPE_MPLS;
+        next_hop_attrs.push_back(next_hop_attr);
+
+        next_hop_attr.id = SAI_NEXT_HOP_ATTR_LABELSTACK;


Could you add SAI_NEXT_HOP_ATTR_OUTSEG_TYPE with push/swap type. Default operation in SAI is swap

@kperumalbfn: If I program the following two routes in FRR: "ip route 20.20.1.1/32 10.0.0.3 label 2021" and "mpls lsp 2020 10.0.0.3 2021", how many SAI NHs are required? It seems like this OUTSEG_TYPE necessitates the NH to have knowledge of the routes reference it and the NH attr content can change depending on the type of route.

Yes @qbdwlr...in this case, there will be 2 MPLS nexthops in SAI. For IP route, MPLS outseg_nexthop with push operation and label 2021. For label 2020, MPLS outseg_nexthop with swap operation and same label 2021. Based on the lookup, select push/swap mpls nexthop.

@qbdwlr Can you also add an option to specify uniform/pipe mode for TTL and EXP in the DB which translates to MPLS nexthop's attribute SAI_NEXT_HOP_ATTR_OUTSEG_TTL_MODE? Default mode is uniform, but in some cases pipe mode is useful.

OUTSEG_TYPE has been added, but not OUTSEG_TTL_MODE since default of uniform is only used for current support.

prsunny

As comments

smaheshm · 2021-04-21T17:49:51Z

fpmsyncd/routesync.cpp

+ *
+ * Return concatenation of NHs: nh0 + "," + nh1 + .... + "," + nhN
+ */
+string RouteSync::getNextHopList(struct rtnl_route *route_obj)


Please add tests for this API. For example, provide different values of "route_obj" and compare with the expected string.

Please refer to the tests provided in sonic-swss/tests/test_route.py:TestMplsRoute

Tests are now moved to new location: sonic-swss/tests/test_route.py:TestMplsRouteFpm

fpmsyncd/routesync.cpp

cfgmgr/intfmgr.cpp

fpmsyncd/routesync.cpp

smaheshm · 2021-04-21T21:20:41Z

fpmsyncd/routesync.cpp

+
+    daddr = rtnl_route_get_dst(route_obj);
+    nl_addr2str(daddr, destaddr, MAX_ADDR_SIZE);
+    SWSS_LOG_INFO("Receive new route message dest addr: %s", destaddr);


"new route" -> "new label route". Would be easier for debugging. Also include the action.

onRouteMsg is used for IP routes, not label routes.

This API is for Label routes only.

@smahesh You are correct. I will fix it.

@smahesh This is fixed.

fpmsyncd/routesync.cpp

smaheshm · 2021-04-21T22:49:28Z

fpmsyncd/routesync.cpp

+    string nexthops = getNextHopList(route_obj);
+    string ifnames = getNextHopIf(route_obj);


It's optional, but I think these two should be in one API that returns a list of Object, which can have "getNexthopList().str()" and "getNextHopIf().str()". May be a list of 'NextHopKey' objects.

orchagent/nexthopkey.h

fpmsyncd/routesync.cpp

smaheshm · 2021-04-21T23:41:37Z

fpmsyncd/routesync.cpp

+ *
+ * Return concatenation of NHs: nh0 + "," + nh1 + .... + "," + nhN
+ */
+string RouteSync::getNextHopList(struct rtnl_route *route_obj)


can you explore if you can resuse "getNextHopGw()" to reduce code duplication?

orchagent/intfsorch.cpp

prsunny · 2021-06-23T20:08:17Z

orchagent/nexthopkey.h

@@ -13,22 +15,40 @@ struct NextHopKey
 {
    IpAddress           ip_address;     // neighbor IP address
    string              alias;          // incoming interface alias
+    sai_next_hop_type_t nh_type;        // NH type


The whole issue with force-push is we lost the commit history and I'm not sure on which commit introduced this change.

@prsunny Are you saying that the nh_type is an issue now? This is something that @smaheshm specifically asked for. I am not sure why having the commit history would be helpful here.

this is a big change; we cannot review the entire code for each commit. So individual commits helps in reviewing the incremental code. Not sure why you've to do force-push multiple times

smaheshm · 2021-06-24T17:05:08Z

/azp run

azure-pipelines · 2021-06-24T17:05:26Z

Azure Pipelines successfully started running 1 pipeline(s).

smaheshm · 2021-06-25T16:07:52Z

/azp run

azure-pipelines · 2021-06-25T16:08:04Z

Azure Pipelines successfully started running 1 pipeline(s).

sonic-mgmt tests added

smaheshm · 2021-06-25T17:00:18Z

orchagent/nexthopkey.h

@@ -131,45 +118,30 @@ struct NextHopKey

    bool isMplsNextHop() const
    {
-        return (nh_type == SAI_NEXT_HOP_TYPE_MPLS);
+        return (!label_stack.empty());


smaheshm · 2021-06-28T15:39:45Z

/azp run

azure-pipelines · 2021-06-28T15:39:56Z

Azure Pipelines successfully started running 1 pipeline(s).

Advance submodule head for sonic-swss 3226163 [BufferOrch] Don't call SAI API for BUFFER_POOL/PROFILE handling in case the op is DEL and the SAI OID is NULL (sonic-net/sonic-swss#1786) 6c88e47 [Dynamic Buffer Calc][Mellanox] Bug fixes and enhancements for the lua plugins for buffer pool calculation and headroom checking (sonic-net/sonic-swss#1781) e86b900 [MPLS] sonic-swss changes for MPLS (sonic-net/sonic-swss#1686) 4c8e2b5 [Dynamic Buffer Calc] Avoid creating lossy PG for admin down ports during initialization (sonic-net/sonic-swss#1776) 3602124 [VS test stability] Skip flaky test for DPB (sonic-net/sonic-swss#1807) c37cc1c Support for in-band-mgmt via management VRF (sonic-net/sonic-swss#1726) 1e3a532 Fix config prompt question issue (sonic-net/sonic-swss#1799) Signed-off-by: Stephen Sun <[email protected]>

VOQ nexthop for remote neighbors should be created on local inband port only for the kernel purpose. SAI should use actual RIF of the remote system port interface. #1686 seems to be break this condition and this change address it.

Advance submodule head for sonic-swss 3226163 [BufferOrch] Don't call SAI API for BUFFER_POOL/PROFILE handling in case the op is DEL and the SAI OID is NULL (sonic-net/sonic-swss#1786) 6c88e47 [Dynamic Buffer Calc][Mellanox] Bug fixes and enhancements for the lua plugins for buffer pool calculation and headroom checking (sonic-net/sonic-swss#1781) e86b900 [MPLS] sonic-swss changes for MPLS (sonic-net/sonic-swss#1686) 4c8e2b5 [Dynamic Buffer Calc] Avoid creating lossy PG for admin down ports during initialization (sonic-net/sonic-swss#1776) 3602124 [VS test stability] Skip flaky test for DPB (sonic-net/sonic-swss#1807) c37cc1c Support for in-band-mgmt via management VRF (sonic-net/sonic-swss#1726) 1e3a532 Fix config prompt question issue (sonic-net/sonic-swss#1799) Signed-off-by: Stephen Sun <[email protected]>

VOQ nexthop for remote neighbors should be created on local inband port only for the kernel purpose. SAI should use actual RIF of the remote system port interface. #1686 seems to be break this condition and this change address it.

SONiC swss support for MPLS: * RouteOrch support for SAI MPLS inseg * NeighOrch support for MPLS NHs. * CrmOrch support for MPLS inseg and NH accounting. * New sonic-swss/tests/test_mpls.py for verification. Unit-tests in sonic-swss/tests/test_mpls.py and sonic-utilities/tests

…c-net#1823) VOQ nexthop for remote neighbors should be created on local inband port only for the kernel purpose. SAI should use actual RIF of the remote system port interface. sonic-net#1686 seems to be break this condition and this change address it.

#### What I did Fix `NameError` from `show version`. ``` admin@str2-7050cx3-acs-02:~$ show version Traceback (most recent call last): File "/usr/local/bin/show", line 8, in <module> sys.exit(cli()) File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 764, in __call__ return self.main(*args, **kwargs) File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 717, in main rv = self.invoke(ctx) File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 1137, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 956, in invoke return ctx.invoke(self.callback, **ctx.params) File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 555, in invoke return callback(*args, **kwargs) File "/usr/local/lib/python3.7/dist-packages/show/main.py", line 960, in version chassis_info = platform.get_chassis_info() File "/usr/local/lib/python3.7/dist-packages/show/platform.py", line 27, in get_chassis_info platform_chassis = sonic_platform.platform.Platform().get_chassis() NameError: name 'sonic_platform' is not defined ``` #### How I did it Import `sonic_platform` before using `sonic_platform`. Signed-off-by: Longxiang Lyu <[email protected]>

qbdwlr mentioned this pull request Mar 31, 2021

MPLS for SONiC infrastructure HLD sonic-net/SONiC#706

Merged

rlhui self-requested a review April 7, 2021 17:34

qbdwlr mentioned this pull request Apr 7, 2021

fix for CRM available bug #1699

Merged

rlhui requested review from abdosi and smaheshm April 8, 2021 16:15

rlhui reviewed Apr 8, 2021

View reviewed changes

orchagent/crmorch.cpp Outdated Show resolved Hide resolved

prsunny reviewed Apr 8, 2021

View reviewed changes

qbdwlr force-pushed the mplsPR branch from 088031a to ed25692 Compare April 9, 2021 18:06

smaheshm reviewed Apr 12, 2021

View reviewed changes

cfgmgr/intfmgr.cpp Show resolved Hide resolved

smaheshm reviewed Apr 12, 2021

View reviewed changes

fpmsyncd/routesync.cpp Outdated Show resolved Hide resolved

smaheshm reviewed Apr 13, 2021

View reviewed changes

fpmsyncd/routesync.cpp Outdated Show resolved Hide resolved

lguohan previously requested changes Apr 16, 2021

View reviewed changes

kperumalbfn reviewed Apr 20, 2021

View reviewed changes

qbdwlr force-pushed the mplsPR branch from da104eb to 8e48907 Compare April 21, 2021 00:41

prsunny requested changes Apr 21, 2021

View reviewed changes