[Dynamic Buffer Calc] Enhance the field checking in table handling #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
|
Originally it was a typo in vstest. During fixing the typo I realized it's lacking the field name checking. So I add them as well. |
neethajohn
approved these changes
Mar 22, 2021
yxieca
pushed a commit
that referenced
this pull request
Mar 26, 2021
…1680) * Fix a typo in test_buffer_dynamic.py and enhance a field name check * Use "else if" instead of "if" Signed-off-by: Stephen Sun <[email protected]>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…onic-net#1680) * Fix a typo in test_buffer_dynamic.py and enhance a field name check * Use "else if" instead of "if" Signed-off-by: Stephen Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Enhance the field checking in table handling
BUFFER_PGhandling.else ifinstead ofifif thefieldmatches one field of the table because in that case, it won't match othersSigned-off-by: Stephen Sun [email protected]
Why I did it
How I verified it
Run vs test and regression test.
Details if related