[acl] Move ACL table constants to acltable.h #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Allen <[email protected]>
|
This pull request fixes 2 alerts when merging 261be48 into 1951365 - view on LGTM.com fixed alerts:
|
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
Signed-off-by: Danny Allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen [email protected]
What I did
I moved all of the ACL table related constants over to acltable.h.
Why I did it
aclorch.h and aclorch.cpp are both huge files that have become hard to maintain/update to support new features. This is part of a bigger effort to try to refactor it to be more manageable.
How I verified it
Confirmed that the compiler doesn't throw any new errors, unit tests still work the same as before, and I ran
test_aclandtest_everflowfrom sonic-mgmt to confirm there is no traffic impact.Details if related