-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vxlanmgrd.cpp #1647
Merged
Merged
Update vxlanmgrd.cpp #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retest this please |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
retest this please |
/Azurepipeline run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
previously approved these changes
Mar 5, 2021
RajeshPukhrajJain
force-pushed
the
master
branch
2 times, most recently
from
March 8, 2021 19:53
255eb1f
to
b4183c2
Compare
RajeshPukhrajJain
force-pushed
the
master
branch
from
March 8, 2021 20:05
b4183c2
to
2a9a959
Compare
prsunny
approved these changes
Mar 8, 2021
daall
pushed a commit
that referenced
this pull request
Mar 12, 2021
Removed the dependency of vxlanmgr to wait for the swss to reconcile during the warmboot process.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
Removed the dependency of vxlanmgr to wait for the swss to reconcile during the warmboot process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Removed the dependency of vxlanmgr to wait for the swss to reconcile during the warmboot process.
Why I did it
The orchagent architecture already address this use-case scenario where it will ensure that the sequence of the new events from application are picked only after replaying all the existing config during the warmboot process.
How I verified it
Tested the warmboot and ensured that the replay/reconcile of the vxlanmgrd is not dependent on the swss reconcile state.
Details if related