Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vstest/subintf] Add vs test to validate sub interface ingress to a vnet #1642

Merged
merged 167 commits into from
Nov 23, 2021
Merged

[vstest/subintf] Add vs test to validate sub interface ingress to a vnet #1642

merged 167 commits into from
Nov 23, 2021

Conversation

wendani
Copy link
Contributor

@wendani wendani commented Feb 15, 2021 •
edited
Loading

What I did
Extended the following vs tests to validate the use case of sub interface ingress linked to a vnet:

  • sub port interface creation
  • sub port interface add ipv4 addresses
  • sub port interface admin status change
  • sub port interface remove ipv4 addresses
  • sub port interface removal

Why I did it
Add vs test to validate that #1521 fixes sonic-net/sonic-buildimage#4238

How I verified it
vs tests

Details if related

vnet is a special vrf with the following limitations as of the current implementation:

  • For next hop object of type IP, only directly connected subnet and single next hop to an IP prefix are supported
  • Directly connected subnet to a router interface is limited to IPv4 when interface is ingress linked to a vnet

vs tests are extended to vnet with the above limitations in mind.

Dedendancy

Incremental change to #1521 base can be found at wendani#1

wendani and others added 30 commits September 29, 2020 19:40
@wendani
Restore eth0 up in post-test clean up
cefc999 
Signed-off-by: Wenda Ni <[email protected]>
@wendani
Merge remote-tracking branch 'origin/master'
155da0a
@wendani
Sub interface inherits parent port mtu changes
b4a10ad 
Signed-off-by: Wenda Ni <[email protected]>
@wendani
Merge remote-tracking branch 'wendani/sub_intf_mtu' into nhg_master
84a5040
@wendani
ecmp hardware convergence acceleration in the event of parent port op…
1481968 
…er status change

Signed-off-by: Wenda Ni <[email protected]>
@wendani
Merge remote-tracking branch 'origin/master' into sub_intf_nhg_master
d87226e 
Signed-off-by: Wenda Ni <[email protected]>
@wendani
Remove redundant string
6345d4d 
Signed-off-by: Wenda Ni <[email protected]>
@wendani
Merge remote-tracking branch 'origin/master' into sub_intf_nhg_master
2898c1f
@wendani
Address comment: refactor code to reuse updatePortOperStatus()
5851e36 
Signed-off-by: Wenda Ni <[email protected]>
@wendani
Refactor
c062f94 
Signed-off-by: Wenda Ni <[email protected]>
@wendani
Refactor
f5f8c45 
Signed-off-by: Wenda Ni <[email protected]>
@wendani
sub interface: alias to hold complete interface name while parentAlias
fb28c95 
holds parent port name

Signed-off-by: wenda.ni <[email protected]>
@wendani
Update comments
71a603c 
Signed-off-by: wenda.ni <[email protected]>
@wendani
Support sub interface in non-global vrf
c3c9e2d 
Signed-off-by: wenda.ni <[email protected]>
@wendani
Init data member
205899d 
Signed-off-by: wenda.ni <[email protected]>
@wendani
vrf extension to test_sub_port_intf_creation
7c93bbe 
Signed-off-by: wenda.ni <[email protected]>
@wendani
Get default vrf oid at instantiation
ccde0be 
Signed-off-by: wenda.ni <[email protected]>
@wendani
vrf extension to test_sub_port_intf_add_ip_addrs
cede478 
Signed-off-by: wenda.ni <[email protected]>
@wendani
vrf extension to test_sub_port_intf_admin_status_change
9c44719 
Signed-off-by: wenda.ni <[email protected]>
@wendani
vrf extension to test_sub_port_intf_remove_ip_addrs
5611112 
Signed-off-by: wenda.ni <[email protected]>
@wendani
vrf extension to test_sub_port_intf_removal
695c188 
Signed-off-by: wenda.ni <[email protected]>
@wendani
vrf extension to test_sub_port_intf_mtu
5c4b86f 
Signed-off-by: wenda.ni <[email protected]>
@wendani
vrf bind test for test_sub_port_intf_creation
2b3e876 
Signed-off-by: wenda.ni <[email protected]>
@wendani
vrf bind test for test_sub_port_intf_add_ip_addrs
390e67a 
Signed-off-by: wenda.ni <[email protected]>
@wendani
vrf bind test for test_sub_port_intf_admin_status_change
7763427 
Signed-off-by: wenda.ni <[email protected]>
@wendani
vrf bind test for test_sub_port_intf_remove_ip_addrs
2d52417 
Signed-off-by: wenda.ni <[email protected]>
@wendani
vrf bind test for test_sub_port_intf_removal
dd3d8d6 
Signed-off-by: wenda.ni <[email protected]>
@wendani
vrf bind test for test_sub_port_intf_mtu
9e79d1a 
Signed-off-by: wenda.ni <[email protected]>
@wendani
vrf test for test_sub_port_intf_nhg_accel
6f85b63 
Signed-off-by: wenda.ni <[email protected]>
@wendani
Reorganize vrf bind test
7b95e72 
Signed-off-by: wenda.ni <[email protected]>
@wendani wendani mentioned this pull request Jun 3, 2021
Merged
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
758128c
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
ac96c49
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
2195bbb
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
7a54b8f
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
3a9ffdc
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
728a4a1
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
5b1da73
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
3ff2d09
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
d9aba6b
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
e0daa22
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
1f85f09
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
3c129f4
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
7ba8cb9
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
0cde8e2
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
25d3aed
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
79994fd
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
7005e66
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
ea531c4
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
4856143
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_vnet_master
41fed3f
@shi-su shi-su merged commit 9639db7 into sonic-net:master Nov 23, 2021
@stephenxs stephenxs mentioned this pull request Nov 29, 2021
Merged
5 tasks
liat-grozovik pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Dec 28, 2021
@stephenxs
[sonic-swss] Submodule update (#9397)
b749c67 
691c37b [Route bulk] Fix bugs in case a SET operation follows a DEL operation in the same bulk (sonic-net/sonic-swss#2086)
a4c80c3 patch for issue sonic-net/sonic-swss#1971 - enable Rx Drop handling for cisco-8000 (sonic-net/sonic-swss#2041)
71751d1 [macsec] Support setting IPG by gearbox_config.json (sonic-net/sonic-swss#2051)
5d5c169 [bulk mode] Fix bulk conflict when in case there are both remove and set operations (sonic-net/sonic-swss#2071)
8bbdbd2 Fix SRV6 NHOP CRM object type (sonic-net/sonic-swss#2072)
ef5b35f [vstest] VS test failure fix after fabric port orch PR merge (sonic-net/sonic-swss#1811)
89ea538 Supply the missing ingress/egress port profile list in document (sonic-net/sonic-swss#2064)
8123437 [pfc_detect] fix RedisReply errors (sonic-net/sonic-swss#2040)
b38f527 [swss][CRM][MPLS] MPLS CRM Nexthop - switch back to using SAI OBJECT rather than SWITCH OBJECT
ae061e5 create debug_shell_enable config to enable debug shell (sonic-net/sonic-swss#2060)
45e446d [cbf] Fix max FC value (sonic-net/sonic-swss#2049)
b1b5b29 Initial p4orch pytest code. (sonic-net/sonic-swss#2054)
d352d5a Update default route status to state DB (sonic-net/sonic-swss#2009)
24a64d6 Orchagent: Integrate P4Orch (sonic-net/sonic-swss#2029)
15a3b6c Delete the IPv6 link-local Neighbor when ipv6 link-local mode is disabled (sonic-net/sonic-swss#1897)
ed783e1 [orchagent] Add trap flow counter support (sonic-net/sonic-swss#1951)
e9b05a3 [vnetorch] ECMP for vnet tunnel routes with endpoint health monitor (sonic-net/sonic-swss#1955)
bcb7d61 P4Orch: inital add of source (sonic-net/sonic-swss#1997)
f6f6f86 [mclaglink] fix acl out ports (sonic-net/sonic-swss#2026)
fd887bf [Reclaim buffer] Reclaim unused buffer for dynamic buffer model (sonic-net/sonic-swss#1910)
9258978 [orchagent, cfgmgr] Add response publisher and state recording (sonic-net/sonic-swss#1992)
3d862a7 Fixing subport vs test script for subport under VNET (sonic-net/sonic-swss#2048)
fb0a5fd Don't handle buffer pool watermark during warm reboot reconciling (sonic-net/sonic-swss#1987)
16d4bcd Routed subinterface enhancements (sonic-net/sonic-swss#1907)
9639db7 [vstest/subintf] Add vs test to validate sub interface ingress to a vnet (sonic-net/sonic-swss#1642)

Signed-off-by: Stephen Sun [email protected]
stephenxs added a commit to stephenxs/sonic-buildimage that referenced this pull request Jan 6, 2022
@stephenxs
[sonic-swss] Submodule update (sonic-net#9397)
e7820ef 
691c37b [Route bulk] Fix bugs in case a SET operation follows a DEL operation in the same bulk (sonic-net/sonic-swss#2086)
a4c80c3 patch for issue sonic-net/sonic-swss#1971 - enable Rx Drop handling for cisco-8000 (sonic-net/sonic-swss#2041)
71751d1 [macsec] Support setting IPG by gearbox_config.json (sonic-net/sonic-swss#2051)
5d5c169 [bulk mode] Fix bulk conflict when in case there are both remove and set operations (sonic-net/sonic-swss#2071)
8bbdbd2 Fix SRV6 NHOP CRM object type (sonic-net/sonic-swss#2072)
ef5b35f [vstest] VS test failure fix after fabric port orch PR merge (sonic-net/sonic-swss#1811)
89ea538 Supply the missing ingress/egress port profile list in document (sonic-net/sonic-swss#2064)
8123437 [pfc_detect] fix RedisReply errors (sonic-net/sonic-swss#2040)
b38f527 [swss][CRM][MPLS] MPLS CRM Nexthop - switch back to using SAI OBJECT rather than SWITCH OBJECT
ae061e5 create debug_shell_enable config to enable debug shell (sonic-net/sonic-swss#2060)
45e446d [cbf] Fix max FC value (sonic-net/sonic-swss#2049)
b1b5b29 Initial p4orch pytest code. (sonic-net/sonic-swss#2054)
d352d5a Update default route status to state DB (sonic-net/sonic-swss#2009)
24a64d6 Orchagent: Integrate P4Orch (sonic-net/sonic-swss#2029)
15a3b6c Delete the IPv6 link-local Neighbor when ipv6 link-local mode is disabled (sonic-net/sonic-swss#1897)
ed783e1 [orchagent] Add trap flow counter support (sonic-net/sonic-swss#1951)
e9b05a3 [vnetorch] ECMP for vnet tunnel routes with endpoint health monitor (sonic-net/sonic-swss#1955)
bcb7d61 P4Orch: inital add of source (sonic-net/sonic-swss#1997)
f6f6f86 [mclaglink] fix acl out ports (sonic-net/sonic-swss#2026)
fd887bf [Reclaim buffer] Reclaim unused buffer for dynamic buffer model (sonic-net/sonic-swss#1910)
9258978 [orchagent, cfgmgr] Add response publisher and state recording (sonic-net/sonic-swss#1992)
3d862a7 Fixing subport vs test script for subport under VNET (sonic-net/sonic-swss#2048)
fb0a5fd Don't handle buffer pool watermark during warm reboot reconciling (sonic-net/sonic-swss#1987)
16d4bcd Routed subinterface enhancements (sonic-net/sonic-swss#1907)
9639db7 [vstest/subintf] Add vs test to validate sub interface ingress to a vnet (sonic-net/sonic-swss#1642)

Signed-off-by: Stephen Sun [email protected]
@stephenxs stephenxs mentioned this pull request Jan 6, 2022
Merged
5 tasks
judyjoseph pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Jan 6, 2022
@stephenxs
[sonic-swss] Submodule update (#9397) (#9685)
6d22c1f 
691c37b [Route bulk] Fix bugs in case a SET operation follows a DEL operation in the same bulk (sonic-net/sonic-swss#2086)
a4c80c3 patch for issue sonic-net/sonic-swss#1971 - enable Rx Drop handling for cisco-8000 (sonic-net/sonic-swss#2041)
71751d1 [macsec] Support setting IPG by gearbox_config.json (sonic-net/sonic-swss#2051)
5d5c169 [bulk mode] Fix bulk conflict when in case there are both remove and set operations (sonic-net/sonic-swss#2071)
8bbdbd2 Fix SRV6 NHOP CRM object type (sonic-net/sonic-swss#2072)
ef5b35f [vstest] VS test failure fix after fabric port orch PR merge (sonic-net/sonic-swss#1811)
89ea538 Supply the missing ingress/egress port profile list in document (sonic-net/sonic-swss#2064)
8123437 [pfc_detect] fix RedisReply errors (sonic-net/sonic-swss#2040)
b38f527 [swss][CRM][MPLS] MPLS CRM Nexthop - switch back to using SAI OBJECT rather than SWITCH OBJECT
ae061e5 create debug_shell_enable config to enable debug shell (sonic-net/sonic-swss#2060)
45e446d [cbf] Fix max FC value (sonic-net/sonic-swss#2049)
b1b5b29 Initial p4orch pytest code. (sonic-net/sonic-swss#2054)
d352d5a Update default route status to state DB (sonic-net/sonic-swss#2009)
24a64d6 Orchagent: Integrate P4Orch (sonic-net/sonic-swss#2029)
15a3b6c Delete the IPv6 link-local Neighbor when ipv6 link-local mode is disabled (sonic-net/sonic-swss#1897)
ed783e1 [orchagent] Add trap flow counter support (sonic-net/sonic-swss#1951)
e9b05a3 [vnetorch] ECMP for vnet tunnel routes with endpoint health monitor (sonic-net/sonic-swss#1955)
bcb7d61 P4Orch: inital add of source (sonic-net/sonic-swss#1997)
f6f6f86 [mclaglink] fix acl out ports (sonic-net/sonic-swss#2026)
fd887bf [Reclaim buffer] Reclaim unused buffer for dynamic buffer model (sonic-net/sonic-swss#1910)
9258978 [orchagent, cfgmgr] Add response publisher and state recording (sonic-net/sonic-swss#1992)
3d862a7 Fixing subport vs test script for subport under VNET (sonic-net/sonic-swss#2048)
fb0a5fd Don't handle buffer pool watermark during warm reboot reconciling (sonic-net/sonic-swss#1987)
16d4bcd Routed subinterface enhancements (sonic-net/sonic-swss#1907)
9639db7 [vstest/subintf] Add vs test to validate sub interface ingress to a vnet (sonic-net/sonic-swss#1642)

Signed-off-by: Stephen Sun [email protected]
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
@vdahiya12
[config] support for configuring muxcable to manual mode of operation (…
a425ca2 
…sonic-net#1642)

What I did
This PR adds support for an option to configure muxcable mode to a manual mode. The manual mode is in addition
to auto/active mode.

The new output would look like this in case an active flag is passed to the command line

admin@sonic:~$ sudo config muxcable mode manual Ethernet0

admin@sonic:~$ sudo config muxcable mode manual all

added an option to set muxcable mode to manual mode, in addition to existing auto/active modes.

How I did it
added the changes in config/muxcable.py and added testcases

How to verify it
Ran the unit tests

Signed-off-by: vaibhav-dahiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny prsunny left review comments

@lguohan lguohan lguohan left review comments

@shi-su shi-su shi-su approved these changes

Assignees
No one assigned
Labels
subport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[VNET] VLAN sub interface RIFs are not assigned to VNET
5 participants
@wendani @lguohan @neethajohn @prsunny @shi-su