Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bufferorch] Handle NOT IMPLEMENTED status returned during set attr operation #1639

Merged
merged 2 commits into from
Feb 13, 2021

Conversation

neethajohn
Copy link
Contributor

Signed-off-by: Neetha John [email protected]

What I did
Set operations for some attributes of buffer pool and buffer profile may not be implemented by some vendors and they return SAI_STATUS_ATTR_NOT_IMPLEMENTED_0. Handle that status in the code and ignore that task

Why I did it
Reduce the noise in the logs due to these operations

How I verified it
With the code changes in place triggered a warm reboot where these were logged as errors and see them logged as NOTICE

@lguohan
Copy link
Contributor

lguohan commented Feb 13, 2021

test failure fixed in #1640

@lguohan lguohan merged commit 32bc1b6 into sonic-net:master Feb 13, 2021
@neethajohn neethajohn deleted the buff_ignore_not_impl branch February 16, 2021 21:28
daall pushed a commit that referenced this pull request Feb 16, 2021
…peration (#1639)

Set operations for some attributes of buffer pool and buffer profile may not be implemented by some vendors and they return SAI_STATUS_ATTR_NOT_IMPLEMENTED_0. Handle that status in the code and ignore that task

Signed-off-by: Neetha John <[email protected]>
DavidZagury pushed a commit to DavidZagury/sonic-swss that referenced this pull request Mar 4, 2021
…peration (sonic-net#1639)

Set operations for some attributes of buffer pool and buffer profile may not be implemented by some vendors and they return SAI_STATUS_ATTR_NOT_IMPLEMENTED_0. Handle that status in the code and ignore that task

Signed-off-by: Neetha John <[email protected]>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
…peration (sonic-net#1639)

Set operations for some attributes of buffer pool and buffer profile may not be implemented by some vendors and they return SAI_STATUS_ATTR_NOT_IMPLEMENTED_0. Handle that status in the code and ignore that task

Signed-off-by: Neetha John <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants