Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitmap_vnet] Remove BMTOR implementation #1494

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

volodymyrsamotiy
Copy link
Collaborator

@volodymyrsamotiy volodymyrsamotiy commented Nov 2, 2020

Signed-off-by: Volodymyr Samotiy [email protected]

What I did
Removed BMTOR implementation

Why I did it
Because BMTOR implementation is deprecated and now VRF is used instead

How I verified it
Ran VNET pytest test

Details if related
N/A

@volodymyrsamotiy volodymyrsamotiy marked this pull request as ready for review November 2, 2020 14:24
@lgtm-com
Copy link

lgtm-com bot commented Nov 2, 2020

This pull request fixes 5 alerts when merging 2e08cdd into a89b8ed - view on LGTM.com

fixed alerts:

  • 2 for Exception thrown in destructor
  • 2 for FIXME comment
  • 1 for Unused local variable

@liat-grozovik liat-grozovik requested a review from prsunny November 2, 2020 19:48
@liat-grozovik
Copy link
Collaborator

liat-grozovik commented Nov 2, 2020

should be merged after sonic-net/sonic-buildimage#5767 is merged to master.
once done, need to cherry pick to 201911

@lguohan lguohan merged commit 62e6c5a into sonic-net:master Nov 4, 2020
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
…how/config muxcable return codes; (sonic-net#1494)

his PR fixes the

show mux hwmode muxdirection
config mux hwmode state
cli commands to correctly use the model values for matching the vendor model value present in TRANSCEIVER_INFO table
in state DB.

This PR also supports the fix for return codes for

show mux
config mux 
commands to return 0 if the command executes correctly.

What I did
fix for show/config muxcable hwmode model value; fix show/config muxcable return codes;

Signed-off-by: vaibhav-dahiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants