Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix array delete and header guard #1327

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Fix array delete and header guard #1327

merged 1 commit into from
Jun 19, 2020

Conversation

qiluo-msft
Copy link
Contributor

No description provided.

jleveque
jleveque approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed that m_messageBuffer_send is not included in the initializer list of the MclagLink constructor. Maybe you can add it as part of this PR for completeness?

daall
daall approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@daall daall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Joe's feedback, rest LGTM.

@lgtm-com
Copy link

lgtm-com bot commented Jun 19, 2020

This pull request fixes 9 alerts when merging 3f44ac6 into 7cc71d1 - view on LGTM.com

fixed alerts:

  • 3 for Missing header guard
  • 3 for Resource not released in destructor
  • 3 for 'new[]' array freed with 'delete'

@qiluo-msft qiluo-msft merged commit 17a2f93 into sonic-net:master Jun 19, 2020
@qiluo-msft qiluo-msft deleted the qiluo/fixlgtm branch June 19, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daall daall daall approved these changes

@yxieca yxieca yxieca approved these changes

@jleveque jleveque jleveque approved these changes

@lguohan lguohan lguohan approved these changes

@pavel-shirshov pavel-shirshov Awaiting requested review from pavel-shirshov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qiluo-msft @lguohan @jleveque @yxieca @daall