[fdb]fdborch: fdb entries are deleted according to vlan or port or vlan&&port #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangshp1987
force-pushed
the
issue#1063
branch
from
0bf309f
to
e51414e
Compare
|
@madhanmellanox , could you please review? |
prsunny
reviewed
May 10, 2021
| SWSS_LOG_NOTICE("Clear fdb by vlan(%s)", vlan.c_str()); | ||
| return; | ||
| } | ||
| else if (op == "PORTVLAN") |
There was a problem hiding this comment.
Can you point to the definition of this op?
There was a problem hiding this comment.
The op comes from my another PR sonic-net/sonic-utilities#657. adding this op(=="PORTVLAN"), developer or operator can delete mac with specify vlan and port in some case.
prsunny
reviewed
May 18, 2021
orchagent/fdborch.cpp
Outdated
| memset(flush_attr,0, sizeof(flush_attr)); | ||
| flush_attr[0].id = SAI_FDB_FLUSH_ATTR_BRIDGE_PORT_ID; | ||
| flush_attr[0].value.oid = port.m_bridge_port_id; | ||
| flush_attr[1].id = SAI_FDB_FLUSH_ATTR_BV_ID; |
There was a problem hiding this comment.
Please use the function - flushFDBEntries instead of repeating the statements.
You can also refer the PR #1716 for the other cases.
prsunny
approved these changes
May 19, 2021
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
Fdb entries can be deleted with user specifying vlan or port or vlan&&port. Signed-off-by: [email protected]
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…onic-net#1064) Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]> The following changes are done - Support show ip(v6) bgp summary for multi asic platforms Add the following 2 multi asic options to the cli command [-n, --namespace] to allow user to display the information for given namespaces If this option is not present the information from all the namespaces will be displayed [-d, --display] to allow user to display information related both internal and external interfaces If this option is not present only external interfaces/neighbors will be display - For FRR bgp containers, get the bgp summary in json and display to the user add a new file bgp_util.py to have all the common bgp related functions. add new functions to get bgp summary from FRR in json, parse the json and render the output - Add unit test for show ip(v4) bgp summary add new unit test to show ip(v4) bgp summary
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
…ndorSai.cpp (sonic-net#1064) introduce function check if sai_query_api_version exists or not configure.ac. If not, then do not call this function in the syncd. Signed-off-by: Guohan Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fdb entries can be deleted with user specifying vlan or port or vlan&&port.The secifying vlan or port can be configured by cli at another issue#565 in Azure / sonic-utilities.
What I did
Why I did it
How I verified it
Details if related