Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGTM analysis always fails due to compiling error on 201911 branch #1889

Closed
stephenxs opened this issue Aug 27, 2021 · 1 comment
Closed

LGTM analysis always fails due to compiling error on 201911 branch #1889

stephenxs opened this issue Aug 27, 2021 · 1 comment

Comments

@stephenxs
Copy link
Collaborator

LGTM failed due to a compiling error which didn't happen when building swss deb.

[2021-06-16 23:14:21] [build-stdout] make  all-recursive
[2021-06-16 23:14:21] [build-stdout] make[1]: Entering directory '/opt/src'
[2021-06-16 23:14:21] [build-stdout] Making all in fpmsyncd
[2021-06-16 23:14:21] [build-stdout] make[2]: Entering directory '/opt/src/fpmsyncd'
[2021-06-16 23:14:21] [build-stdout] g++ -DHAVE_CONFIG_H -I. -I.. -I .. -I ../warmrestart -I  -g  -std=c++14 -Wall -fPIC -Wno-write-strings -I/usr/include/libnl3 -I/usr/include/swss -Werror -Wno-reorder -Wcast-align -Wcast-qual -Wconversion -Wdisabled-optimization -Wextra -Wfloat-equal -Wformat=2 -Wformat-nonliteral -Wformat-security -Wformat-y2k -Wimport -Winit-self -Winvalid-pch -Wlong-long -Wmissing-field-initializers -Wmissing-format-attribute -Wno-aggregate-return -Wno-padded -Wno-switch-enum -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wstack-protector -Wstrict-aliasing=3 -Wswitch -Wswitch-default -Wunreachable-code -Wunused -Wvariadic-macros -Wno-switch-default -Wno-long-long -Wno-redundant-decls   -fpermissive -MT fpmsyncd-fpmsyncd.o -MD -MP -MF .deps/fpmsyncd-fpmsyncd.Tpo -c -o fpmsyncd-fpmsyncd.o `test -f 'fpmsyncd.cpp' || echo './'`fpmsyncd.cpp
[2021-06-16 23:14:22] [build-stderr] fpmsyncd.cpp:3:10: fatal error: logger.h: No such file or directory
[2021-06-16 23:14:22] [build-stderr]     3 | #include "logger.h"
[2021-06-16 23:14:22] [build-stderr]       |          ^~~~~~~~~~
[2021-06-16 23:14:22] [build-stderr] compilation terminated.
[2021-06-16 23:14:24] [build-stdout] make[2]: Leaving directory '/opt/src/fpmsyncd'
[2021-06-16 23:14:24] [build-stderr] make[2]: *** [Makefile:434: fpmsyncd-fpmsyncd.o] Error 1
[2021-06-16 23:14:24] [build-stderr] make[1]: *** [Makefile:404: all-recursive] Error 1
[2021-06-16 23:14:24] [build-stdout] make[1]: Leaving directory '/opt/src'
[2021-06-16 23:14:24] [build-stderr] make: *** [Makefile:336: all] Error 2
[2021-06-16 23:14:24] [build-stdout] Semmle autobuild: no supported build system detected.

this error occurred in PR #1787 , #1837
@stephenxs
Copy link
Collaborator Author

Fixed by #1901

EdenGri pushed a commit to EdenGri/sonic-swss that referenced this issue Feb 28, 2022
@liuh-80
[TACACS+] Add config command for AAA authorization and accounting. (s…
63a5257 
…onic-net#1889)

This pull request add config command for AAA authorization & accounting.

#### Why I did it
    Support TACACS per-command authorization & accounting.

#### How I did it
    Change AAA config command to support authorization & accounting.
    Change show AAA command to support authorization & accounting.
    Add UT to cover changed code.

#### How to verify it
    1. Build following project and pass all UTs:
        make target/python-wheels/sonic_utilities-1.2-py3-none-any.whl
    2. Test new command manually.

#### Which release branch to backport (provide reason below if selected)
    N/A

#### Description for the changelog
    Add config command for AAA authorization & accounting.

#### A picture of a cute animal (not mandatory but encouraged)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephenxs