Restructure

sonic-net · Oct 19, 2021 · cd49fff · cd49fff
1 parent 0ae4eb7
commit cd49fff
Show file tree

Hide file tree

Showing 4 changed files with 53 additions and 86 deletions.
diff --git a/orchagent/Makefile.am b/orchagent/Makefile.am
@@ -40,7 +40,6 @@ orchagent_SOURCES = \
             orchdaemon.cpp \
             orch.cpp \
             notifications.cpp \
-            nhgorch.cpp \
             nhg/nhgbase.cpp \
             nhg/nhghandler.cpp \
             nhg/cbfnhghandler.cpp  \

diff --git a/orchagent/nhgorch.cpp b/orchagent/nhgorch.cpp
diff --git a/orchagent/nhgorch.h b/orchagent/nhgorch.h
@@ -3,10 +3,12 @@
 #include "nhg/cbfnhghandler.h"
 #include "nhg/nhghandler.h"
 #include "vector"
+#include "portsorch.h"
 #include "routeorch.h"
 
 using namespace std;
 
+extern PortsOrch *gPortsOrch;
 extern RouteOrch *gRouteOrch;
 
 /*
@@ -19,8 +21,11 @@ class NhgOrch : public Orch
     /*
      * Constructor.
      */
-    NhgOrch(DBConnector *db, const vector<string> &table_names);
-
+    NhgOrch(DBConnector *db, const vector<string> &table_names) :
+        Orch(db, table_names)
+    {
+        SWSS_LOG_ENTER();
+    }
     /* Check if the next hop group given by it's index exists. */
     inline bool hasNhg(const std::string& index) const
     {
@@ -54,8 +59,32 @@ class NhgOrch : public Orch
     inline void decSyncedNhgCount() { NhgBase::decSyncedCount(); }
 
     /* Increase / Decrease ref count for a NHG given by it's index. */
-    void incNhgRefCount(const std::string& index);
-    void decNhgRefCount(const std::string& index);
+    void incNhgRefCount(const std::string& index)
+    {
+        SWSS_LOG_ENTER();
+
+        if (nhgHandler.hasNhg(index))
+        {
+            nhgHandler.incNhgRefCount(index);
+        }
+        else
+        {
+            cbfNhgHandler.incNhgRefCount(index);
+        }
+    }
+    void decNhgRefCount(const std::string& index)
+    {
+        SWSS_LOG_ENTER();
+
+        if (nhgHandler.hasNhg(index))
+        {
+            nhgHandler.decNhgRefCount(index);
+        }
+        else
+        {
+            cbfNhgHandler.decNhgRefCount(index);
+        }
+    }
 
     /* Handling SAI status*/
     task_process_status handleSaiCreateStatus(sai_api_t api, sai_status_t status, void *context = nullptr)
@@ -72,5 +101,24 @@ class NhgOrch : public Orch
     CbfNhgHandler cbfNhgHandler;
 private:
 
-    void doTask(Consumer& consumer);
+    void doTask(Consumer& consumer)
+    {
+        SWSS_LOG_ENTER();
+
+        if (!gPortsOrch->allPortsReady())
+        {
+            return;
+        }
+
+        string table_name = consumer.getTableName();
+
+        if (table_name == APP_NEXTHOP_GROUP_TABLE_NAME)
+        {
+            nhgHandler.doTask(consumer);
+        }
+        else if (table_name == APP_CLASS_BASED_NEXT_HOP_GROUP_TABLE_NAME)
+        {
+            cbfNhgHandler.doTask(consumer);
+        }
+    }
 };
diff --git a/tests/mock_tests/Makefile.am b/tests/mock_tests/Makefile.am
@@ -39,7 +39,6 @@ tests_SOURCES = aclorch_ut.cpp \
                 $(top_srcdir)/orchagent/routeorch.cpp \
                 $(top_srcdir)/orchagent/mplsrouteorch.cpp \
                 $(top_srcdir)/orchagent/fgnhgorch.cpp \
-                $(top_srcdir)/orchagent/nhgorch.cpp \
                 $(top_srcdir)/orchagent/nhg/nhgbase.cpp \
                 $(top_srcdir)/orchagent/nhg/nhghandler.cpp \
                 $(top_srcdir)/orchagent/nhg/cbfnhghandler.cpp \