Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debian/control] libswsscommon-dev depends on libboost-dev #458

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

stepanblyschak
Copy link
Contributor

libswsscommon-dev is not usable without libboost-dev package, meaning I cannot compile with headers which include boost libraries. Make it implicitly install by apt-get install -f

Signed-off-by: Stepan Blyshchak [email protected]

@qiluo-msft
Copy link
Contributor

@tahmed-dev please help review

@tahmed-dev
Copy link
Contributor

@tahmed-dev please help review
Thanks @qiluo-msft and @stepanblyschak . Stepan, can you please shed light on the use case, here? libboost-dev is installed in the stretch/buster build dockers

Copy link
Contributor

@tahmed-dev tahmed-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just curious about the use case.

@stepanblyschak
Copy link
Contributor Author

@tahmed-dev @qiluo-msft The use case is to implicitelly install -dev dependencies in sonic-sdk-buildenv docker sonic-net/sonic-buildimage#6712 instead of installing it explicitelly.

@tahmed-dev
Copy link
Contributor

@tahmed-dev @qiluo-msft The use case is to implicitelly install -dev dependencies in sonic-sdk-buildenv docker Azure/sonic-buildimage#6712 instead of installing it explicitelly.

Curious to know which boost v is being installed in the sonic-sdk-buildenv. Which version gets pulled 1.67 or v1.71?

@stepanblyschak
Copy link
Contributor Author

@tahmed-dev 1.67 is getting installed. Which one is required? From what I saw in Build-Depends it can work with either of them

@tahmed-dev
Copy link
Contributor

@tahmed-dev 1.67 is getting installed. Which one is required? From what I saw in Build-Depends it can work with either of them

We are running v1.71 which is backported to buster. However it doesn't resolve dependency on generic libboost and so we opted to install it explicitly for buster. swss common dependency is compile time AFAIK, however if it take dependency on specific version, it will pull it and we end up with two libboost versions. So, you might wanna install v 1.71 in you target to have libboost version aligned across different containers.

@stepanblyschak
Copy link
Contributor Author

@tahmed-dev 1.67 is getting installed. Which one is required? From what I saw in Build-Depends it can work with either of them

We are running v1.71 which is backported to buster. However it doesn't resolve dependency on generic libboost and so we opted to install it explicitly for buster. swss common dependency is compile time AFAIK, however if it take dependency on specific version, it will pull it and we end up with two libboost versions. So, you might wanna install v 1.71 in you target to have libboost version aligned across different containers.

@tahmed-dev If you want to give preference to 1.71 then we should specify "libboost1.71-dev | libboost-dev". With such reorder 1.71 got installed in sonic-sdk.

I would like to avoid explicit dependency installations in my SDK docker. Let me know what do you think

@tahmed-dev
Copy link
Contributor

@tahmed-dev 1.67 is getting installed. Which one is required? From what I saw in Build-Depends it can work with either of them

We are running v1.71 which is backported to buster. However it doesn't resolve dependency on generic libboost and so we opted to install it explicitly for buster. swss common dependency is compile time AFAIK, however if it take dependency on specific version, it will pull it and we end up with two libboost versions. So, you might wanna install v 1.71 in you target to have libboost version aligned across different containers.

@tahmed-dev If you want to give preference to 1.71 then we should specify "libboost1.71-dev | libboost-dev". With such reorder 1.71 got installed in sonic-sdk.

I would like to avoid explicit dependency installations in my SDK docker. Let me know what do you think

Thanks @stepanblyschak ! That would work great!

@qiluo-msft qiluo-msft merged commit f01fede into sonic-net:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants