-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[debian/control] libswsscommon-dev depends on libboost-dev #458
Conversation
Signed-off-by: Stepan Blyshchak <[email protected]>
@tahmed-dev please help review |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just curious about the use case.
@tahmed-dev @qiluo-msft The use case is to implicitelly install -dev dependencies in sonic-sdk-buildenv docker sonic-net/sonic-buildimage#6712 instead of installing it explicitelly. |
Curious to know which boost v is being installed in the sonic-sdk-buildenv. Which version gets pulled 1.67 or v1.71? |
@tahmed-dev 1.67 is getting installed. Which one is required? From what I saw in Build-Depends it can work with either of them |
We are running v1.71 which is backported to buster. However it doesn't resolve dependency on generic |
@tahmed-dev If you want to give preference to 1.71 then we should specify "libboost1.71-dev | libboost-dev". With such reorder 1.71 got installed in sonic-sdk. I would like to avoid explicit dependency installations in my SDK docker. Let me know what do you think |
Thanks @stepanblyschak ! That would work great! |
libswsscommon-dev is not usable without libboost-dev package, meaning I cannot compile with headers which include boost libraries. Make it implicitly install by apt-get install -f
Signed-off-by: Stepan Blyshchak [email protected]