Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move RedisClient functions into DBConnector #382

Merged
merged 5 commits into from
Sep 17, 2020
Merged

Move RedisClient functions into DBConnector #382

merged 5 commits into from
Sep 17, 2020

Conversation

qiluo-msft
Copy link
Contributor

@qiluo-msft qiluo-msft commented Sep 13, 2020 •
edited
Loading

The member functions of class RedisClient fit well in the class DBConnector, and there is not benefit of standalone RedisClient class. So we are trying to deprecated the class RedisClient.

Steps:

prsunny
prsunny approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@prsunny prsunny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, suggest wait for other reviewers.

common/redisclient.h Show resolved Hide resolved
shi-su
shi-su approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@shi-su shi-su left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@qiluo-msft qiluo-msft merged commit 2b9a00f into sonic-net:master Sep 17, 2020
@qiluo-msft qiluo-msft deleted the qiluo/noclient branch September 17, 2020 01:45
qiluo-msft added a commit to qiluo-msft/sonic-swss that referenced this pull request Sep 17, 2020
@qiluo-msft
Replace RedisClient with DBConnector
51a753e 
After this PR: sonic-net/sonic-swss-common#382
@qiluo-msft qiluo-msft mentioned this pull request Sep 17, 2020
Merged
qiluo-msft added a commit to qiluo-msft/sonic-sairedis that referenced this pull request Sep 17, 2020
@qiluo-msft
Replace RedisClient with DBConnector
f801c0e 
After this PR: sonic-net/sonic-swss-common#382
@qiluo-msft qiluo-msft mentioned this pull request Sep 17, 2020
Merged
qiluo-msft added a commit to sonic-net/sonic-sairedis that referenced this pull request Sep 17, 2020
@qiluo-msft
Replace RedisClient with DBConnector (#660)
6117cf5 
After this PR: sonic-net/sonic-swss-common#382
qiluo-msft added a commit to sonic-net/sonic-swss that referenced this pull request Sep 18, 2020
@qiluo-msft
Replace RedisClient with DBConnector (#1439)
b4938a5 
After this PR: sonic-net/sonic-swss-common#382
kktheballer pushed a commit to kktheballer/sonic-swss-common that referenced this pull request Dec 9, 2020
@qiluo-msft @kktheballer
Move RedisClient functions into DBConnector (sonic-net#382)
6b95d0e 
* Move RedisClient functions into DBConnector
* RedisClient redirects all functions to DBConnector
* Remove cpp file
* Remove RedisClient
* Add TODO comment
kktheballer pushed a commit to kktheballer/sonic-swss that referenced this pull request Dec 9, 2020
@qiluo-msft @kktheballer
Replace RedisClient with DBConnector (sonic-net#1439)
ac65db7 
After this PR: sonic-net/sonic-swss-common#382
kktheballer pushed a commit to kktheballer/sonic-swss that referenced this pull request Dec 20, 2020
@qiluo-msft @kktheballer
Replace RedisClient with DBConnector (sonic-net#1439)
ed9e7fc 
After this PR: sonic-net/sonic-swss-common#382
kktheballer pushed a commit to kktheballer/sonic-swss-common that referenced this pull request Dec 20, 2020
@qiluo-msft @kktheballer
Move RedisClient functions into DBConnector (sonic-net#382)
508bb62 
* Move RedisClient functions into DBConnector
* RedisClient redirects all functions to DBConnector
* Remove cpp file
* Remove RedisClient
* Add TODO comment
kktheballer pushed a commit to kktheballer/sonic-swss-common that referenced this pull request Dec 21, 2020
@qiluo-msft @kktheballer
Move RedisClient functions into DBConnector (sonic-net#382)
f4ac451 
* Move RedisClient functions into DBConnector
* RedisClient redirects all functions to DBConnector
* Remove cpp file
* Remove RedisClient
* Add TODO comment
kktheballer pushed a commit to kktheballer/sonic-swss that referenced this pull request Jan 21, 2021
@qiluo-msft
Replace RedisClient with DBConnector (sonic-net#1439)
3bd45f9 
After this PR: sonic-net/sonic-swss-common#382
kktheballer pushed a commit to kktheballer/sonic-swss-common that referenced this pull request Jan 21, 2021
@qiluo-msft
Move RedisClient functions into DBConnector (sonic-net#382)
8fe4269 
* Move RedisClient functions into DBConnector
* RedisClient redirects all functions to DBConnector
* Remove cpp file
* Remove RedisClient
* Add TODO comment
anish-n pushed a commit to anish-n/sonic-swss that referenced this pull request Feb 25, 2021
@qiluo-msft @anish-n
Replace RedisClient with DBConnector (sonic-net#1439)
7a70c1c 
After this PR: sonic-net/sonic-swss-common#382
kktheballer pushed a commit to kktheballer/sonic-swss-common that referenced this pull request Feb 25, 2021
@qiluo-msft @kktheballer
Move RedisClient functions into DBConnector (sonic-net#382)
c231362 
* Move RedisClient functions into DBConnector
* RedisClient redirects all functions to DBConnector
* Remove cpp file
* Remove RedisClient
* Add TODO comment
kktheballer pushed a commit to kktheballer/sonic-swss that referenced this pull request Jul 20, 2021
@qiluo-msft @kktheballer
Replace RedisClient with DBConnector (sonic-net#1439)
487d8a8 
After this PR: sonic-net/sonic-swss-common#382
kktheballer pushed a commit to kktheballer/sonic-swss-common that referenced this pull request Jul 20, 2021
@qiluo-msft @kktheballer
Move RedisClient functions into DBConnector (sonic-net#382)
47b2d47 
* Move RedisClient functions into DBConnector
* RedisClient redirects all functions to DBConnector
* Remove cpp file
* Remove RedisClient
* Add TODO comment
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
@qiluo-msft
Replace RedisClient with DBConnector (sonic-net#660)
7ae5883 
After this PR: sonic-net/sonic-swss-common#382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shi-su shi-su shi-su approved these changes

@prsunny prsunny prsunny approved these changes

@lguohan lguohan Awaiting requested review from lguohan

@jleveque jleveque Awaiting requested review from jleveque

@pavel-shirshov pavel-shirshov Awaiting requested review from pavel-shirshov

@kcudnik kcudnik Awaiting requested review from kcudnik

@daall daall Awaiting requested review from daall

@yxieca yxieca Awaiting requested review from yxieca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qiluo-msft @prsunny @shi-su