-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system warm-reboot check in WarmRestart class #246
Add system warm-reboot check in WarmRestart class #246
Conversation
UT test is also updated
The change looks ok to me. What is the use case? Ex. for swss docker restart, if the processes see system warm restart flag, it will do warm data reload. But seeing the flag enabled doesn't mean system level reboot is in progress, it may just be a docker warm restart. |
This PR is for the system level warm reboot related processes. E,g, neighbor table restore during the system warm reboot. We will check the system level reboot flag and make distinction between pure docker warm restart and system level warm reboot. |
Signed-off-by: Zhenggen Xu <[email protected]>
Also added the WarmRestart class to python binding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok to me. please resolve other reviewers' comments.
Add flag for checkWarmStart to increase the restore count or not Signed-off-by: Zhenggen Xu <[email protected]>
Done the renaming, also added a flag to increase the restore count or not. |
Add system warm-reboot check in WarmRestart class
UT test is also updated
Add the WarmRestart Class to python binding