Update restart_waiter_ut (#742)

Update restart_waiter_ut to use "enable"/"disable" as values for fast-reboot entry in state-db. This PR should come along with the following PRs: sonic-net/sonic-utilities#2621 sonic-net/sonic-buildimage#13484 sonic-net/sonic-platform-daemons#335 sonic-net/sonic-sairedis#1196 This set of PRs solves the issue sonic-net/sonic-buildimage#13251
sonic-net · Apr 11, 2023 · 91b0b18 · 91b0b18
1 parent 2b0fb67
commit 91b0b18
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 8 deletions.
diff --git a/common/restart_waiter.cpp b/common/restart_waiter.cpp
@@ -11,7 +11,7 @@ static const std::string STATE_DB_NAME = "STATE_DB";
 static const std::string STATE_DB_SEPARATOR = "|";
 static const std::string RESTART_KEY = "system";
 static const std::string RESTART_ENABLE_FIELD = "enable";
-static const std::string FAST_REBOOT_TABLE_NAME = "FAST_REBOOT";
+static const std::string FAST_REBOOT_TABLE_NAME = "FAST_RESTART_ENABLE_TABLE";
 
 // waitAdvancedBootDone
 bool RestartWaiter::waitAdvancedBootDone(
@@ -71,7 +71,14 @@ bool RestartWaiter::doWait(DBConnector &stateDb,
 
 bool RestartWaiter::isAdvancedBootInProgress(DBConnector &stateDb)
 {
-    auto ret = stateDb.hget(STATE_WARM_RESTART_ENABLE_TABLE_NAME + STATE_DB_SEPARATOR + RESTART_KEY, RESTART_ENABLE_FIELD);
+    return isAdvancedBootInProgressHelper(stateDb);
+}
+
+bool RestartWaiter::isAdvancedBootInProgressHelper(DBConnector &stateDb,
+                                                   bool checkFastBoot)
+{
+    std::string table_name = checkFastBoot ? FAST_REBOOT_TABLE_NAME : STATE_WARM_RESTART_ENABLE_TABLE_NAME;
+    auto ret = stateDb.hget(table_name + STATE_DB_SEPARATOR + RESTART_KEY, RESTART_ENABLE_FIELD);
     if (ret) {
         std::string value = *ret.get();
         boost::to_lower(value);
@@ -82,8 +89,7 @@ bool RestartWaiter::isAdvancedBootInProgress(DBConnector &stateDb)
 
 bool RestartWaiter::isFastBootInProgress(DBConnector &stateDb)
 {
-    auto ret = stateDb.get(FAST_REBOOT_TABLE_NAME + STATE_DB_SEPARATOR + RESTART_KEY);
-    return ret.get() != nullptr;
+    return isAdvancedBootInProgressHelper(stateDb, true);
 }
 
 bool RestartWaiter::isWarmBootInProgress(swss::DBConnector &stateDb)

diff --git a/common/restart_waiter.h b/common/restart_waiter.h
@@ -20,7 +20,9 @@ class RestartWaiter
     static bool waitFastBootDone(unsigned int maxWaitSec = 180,
                                     unsigned int dbTimeout = 0,
                                     bool isTcpConn = false);
-
+
+    static bool isAdvancedBootInProgressHelper(swss::DBConnector &stateDb,
+                                                bool checkFastBoot = false);
     static bool isAdvancedBootInProgress(swss::DBConnector &stateDb);
     static bool isFastBootInProgress(swss::DBConnector &stateDb);
     static bool isWarmBootInProgress(swss::DBConnector &stateDb);

diff --git a/tests/restart_waiter_ut.cpp b/tests/restart_waiter_ut.cpp
@@ -12,7 +12,7 @@
 using namespace swss;
 using namespace std;
 
-static const string FAST_REBOOT_KEY = "FAST_REBOOT|system";
+static const string FAST_REBOOT_KEY = "FAST_RESTART_ENABLE_TABLE|system";
 
 static void set_reboot_status(string status, int delay = 0)
 {
@@ -31,12 +31,12 @@ class FastBootHelper
 public:
     FastBootHelper(): db("STATE_DB", 0)
     {
-        db.set(FAST_REBOOT_KEY, "1");
+        db.hset(FAST_REBOOT_KEY, "enable", "true");
     }
 
     ~FastBootHelper()
     {
-        db.del({FAST_REBOOT_KEY});
+        db.hset(FAST_REBOOT_KEY, "enable", "false");
     }
 private:
     DBConnector db;