use a set to make sure no duplicate channels are added

sonic-net · Aug 26, 2024 · 5c0a375 · 5c0a375
1 parent b512a9a
commit 5c0a375
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/common/redispipeline.h b/common/redispipeline.h
@@ -2,6 +2,7 @@
 
 #include <string>
 #include <queue>
+#include <unordered_set>
 #include <functional>
 #include <chrono>
 #include <iostream>
@@ -159,9 +160,11 @@ class RedisPipeline {
 
     void addChannel(std::string channel)
     {
-        m_luaPub +=
-        "redis.call('PUBLISH', '" + channel + "', 'G');";
+        if (m_channels.find(channel) != m_channels.end())
+            return;
 
+        m_channels.insert(channel);
+        m_luaPub += "redis.call('PUBLISH', '" + channel + "', 'G');";
         m_shaPub = loadRedisScript(m_luaPub);
     }
 
@@ -178,7 +181,8 @@ class RedisPipeline {
 
     std::string m_luaPub;
     std::string m_shaPub;
-    std::chrono::time_point<std::chrono::steady_clock> lastHeartBeat;
+    std::chrono::time_point<std::chrono::steady_clock> lastHeartBeat; // marks the timestamp of latest pipeline flush being invoked
+    std::unordered_set<std::string> m_channels;
 
     void publish() {
         if (m_shaPub == "") {