Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonic-sairedis updates for MPLS #824

Merged
merged 1 commit into from
Jun 16, 2021
Merged

sonic-sairedis updates for MPLS #824

merged 1 commit into from
Jun 16, 2021

Conversation

qbdwlr
Copy link
Contributor

@qbdwlr qbdwlr commented Apr 21, 2021

What I did
Minor tweaks to VS for MPLS support for CRM polling of MPLS In-segments and NHs.

Why I did it
Allows MPLS CRM support to function properly with VS.

How I verified it
Unit-tests in sonic-swss/tests/test_mpls.py.

Details if related
Refer to HLD: sonic-net/SONiC#706

meta/Meta.cpp Outdated Show resolved Hide resolved
meta/Meta.cpp Show resolved Hide resolved
kcudnik
kcudnik previously approved these changes May 5, 2021
kcudnik
kcudnik previously approved these changes May 11, 2021
@qbdwlr
Copy link
Contributor Author

qbdwlr commented Jun 5, 2021

@kcudnik I will need you to approve this PR yet again since the rest of the MPLS PRs are thisclose to approval, but this PR seems to have perpetual and unrelated issues with the Azure pipeline. What can I do about this?

kcudnik
kcudnik previously approved these changes Jun 6, 2021
kcudnik
kcudnik previously approved these changes Jun 7, 2021
@abdosi
Copy link
Contributor

abdosi commented Jun 7, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qbdwlr qbdwlr requested a review from kcudnik June 14, 2021 19:00
@qbdwlr
Copy link
Contributor Author

qbdwlr commented Jun 14, 2021

@kcudnik Finally got a good pipeline run. Can you approve/merge this now?

Copy link
Collaborator

@kcudnik kcudnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@qbdwlr qbdwlr requested a review from kcudnik June 15, 2021 00:06
kcudnik
kcudnik previously approved these changes Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants