Add synchronous switch controlled by CONFIG_DB #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Aug 21, 2020
| @@ -24,6 +24,12 @@ fi | |||
| # Use temporary view between init and apply | |||
| CMD_ARGS+=" -u" | |||
|
|
|||
| # Set synchronous mode if it is enabled in CONFIG_DB | |||
| SYNC_MODE=$(sonic-cfggen -d -v DEVICE_METADATA.localhost.synchronous_mode) | |||
There was a problem hiding this comment.
synchronous_mode [](start = 57, length = 16)
Did you test when the field is missing, as in old image?
There was a problem hiding this comment.
Yes, it will receive an empty thing and skip changing CMD_ARGS. Basically, it will do async mode.
qiluo-msft
reviewed
Aug 21, 2020
| @@ -24,6 +24,12 @@ fi | |||
| # Use temporary view between init and apply | |||
| CMD_ARGS+=" -u" | |||
|
|
|||
| # Set synchronous mode if it is enabled in CONFIG_DB | |||
| SYNC_MODE=$(sonic-cfggen -d -v DEVICE_METADATA.localhost.synchronous_mode) | |||
There was a problem hiding this comment.
synchronous_mode [](start = 57, length = 16)
Also change https://github.com/Azure/SONiC/wiki/Configuration#device-metadata?
There was a problem hiding this comment.
Added it to the page.
qiluo-msft
approved these changes
Aug 22, 2020
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-What I did
Let syncd check CONFIG_DB for whether to enable synchronous mode and initialize with the mode selected.
-Why I did it
To allow master control of synchronous mode and allow configuring the mode for orchagent and syncd.
-How I did it
Let syncd check the mode in CONFIG_DB in
syncd_init_common.sh-How I verified it
Test locally with a virtual switch.
-Details if related
Related to #sonic-net/sonic-buildimage/pull/5237