Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify syncd init script for supporting yml #1474

Merged

Conversation

geans-pin
Copy link
Contributor

No description provided.

@geans-pin geans-pin changed the title new commit new commit with same changes from PR1411 Nov 28, 2024
@geans-pin
Copy link
Contributor Author

/AzurePipelines run

Copy link

Commenter does not have sufficient privileges for PR 1474 in repo sonic-net/sonic-sairedis

@kcudnik
Copy link
Collaborator

kcudnik commented Nov 28, 2024

changes like this should be cherrypicked and have the same name as original PR not "new commit same as"

@geans-pin geans-pin changed the title new commit with same changes from PR1411 modify syncd init script for supporting yml Nov 28, 2024
@geans-pin
Copy link
Contributor Author

Any idea of the Azure Pipelines 13 ran longer than the maximum time of 60 mins ?

##[error]The job running on agent Azure Pipelines 13 ran longer than the maximum time of 60 minutes. For more information, see https://go.microsoft.com/fwlink/?linkid=2077134
Agent: Azure Pipelines 13
Started: Today at 下午2:30
Duration: 1h 0m 7s

Job preparation parameters
9 queue time variables used
1 artifact produced

@geans-pin
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kcudnik
Copy link
Collaborator

kcudnik commented Nov 28, 2024

2024-11-28T06:54:18.5245096Z [       OK ] ClientServerSai.FDB_ENTRY (8 ms)
2024-11-28T06:54:18.5245628Z [ RUN      ] ClientServerSai.FLOW_ENTRY
2024-11-28T07:30:08.7223662Z ##[error]The Operation will be canceled. The next steps may not contain expected logs.
2024-11-28T07:30:08.7401297Z ##[error]The operation was canceled.
2024-11-28T07:30:08.7405562Z ##[section]Finishing: Run sonic sairedis unit tests

usually build process is les than 30 min, but here for somehow its stuck on FLOW_ENTRY, you would nedd to download syslog from that build and analyse syslog what went wrong

@geans-pin
Copy link
Contributor Author

With /azpw run, all checker pass

@Praveen-Brcm
Copy link

@ZhaohuiS Can you please help approve and merge the PR. All checks are passing now.

@adyeung
Copy link

adyeung commented Dec 2, 2024

@ZhaohuiS @StormLiangMS please review and signoff if there is no further comments

###BRCM Common config UT####
HWSKU_DIR=/usr/share/sonic/hwsku
PLATFORM_COMMON_DIR=/usr/share/sonic/device/x86_64-broadcom_common
PLT_SAI_PROFILE=$(find $HWSKU_DIR -name 'sai.profile')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geans-pin same sai.profile location issue for ut test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply the same change in the new commit for UT script

@ZhaohuiS
Copy link

ZhaohuiS commented Dec 3, 2024

@ZhaohuiS @StormLiangMS please review and signoff if there is no further comments

@adyeung I found same sai.profile location issue for UT script. Could you please test it and verify if it works then submit the commits?

change sai.profile search path from HWSKU to /etc/sai.d
@geans-pin
Copy link
Contributor Author

geans-pin commented Dec 3, 2024

@ZhaohuiS @StormLiangMS please review and signoff if there is no further comments

@adyeung I found same sai.profile location issue for UT script. Could you please test it and verify if it works then submit the commits?

WIth or Without the sai.profile search path change for all the MICAS platforms we have, the function and UT works well.
Apply the same search path change to UT script in the new commit. Please help to verify on your specific platform with different location of sai.profile.

List the Micas platforms which we have verified :
M2-W6510-48V8C (TD3X7)
M2-W6930-64QC (TH4)
M2-W6920-32QC2X (TH3)
M2-W6510-48GT4V (TD3X2)
M2-W6520-24DC8QC (TD4)
M2-W6510-32C (TD3X7)

Copy link

@ZhaohuiS ZhaohuiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on 7260cx3/7060/7050cx3/s6100, it works.

@vishnushetty vishnushetty merged commit 8ba9448 into sonic-net:master Dec 3, 2024
18 checks passed
shiraez pushed a commit to Marvell-switching/sonic-sairedis that referenced this pull request Dec 12, 2024
* new commit

* Change sai profile search path to /etc/sai.d

* Update brcm_common_config_ut.sh

change sai.profile search path from HWSKU to /etc/sai.d
shiraez pushed a commit to Marvell-switching/sonic-sairedis that referenced this pull request Dec 12, 2024
* new commit

* Change sai profile search path to /etc/sai.d

* Update brcm_common_config_ut.sh

change sai.profile search path from HWSKU to /etc/sai.d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants