Merge vector packet processing (vpp) from sonic-platform-vpp with virtual switch #1473
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This is ready for review |
i just made build from source on azp in sairedis just for test: #1486 if this will succeed, thatn we can just copy that to azpipeline on sonic-platform-vpp if noowne is working on that yet |
|
seems like vpp build succeeded on azure pipeline: https://dev.azure.com/mssonic/build/_build/results?buildId=724631&view=logs&j=d755766c-c33e-5abe-260c-8d11f335b1a1&t=f2559076-9bdb-5064-4af2-83c32f011787 it took a little bit over 1 hour, first build fialed, nto sure why, but second one after restart succeeded :) |
| DISABLED_FLAGS= \ | ||
| -Wno-unused-function \ | ||
| -Wno-sign-conversion \ | ||
| -Wno-conversion \ | ||
| -Wno-unused-variable \ | ||
| -Wno-sign-compare \ | ||
| -Wno-shadow \ | ||
| -Wno-discarded-qualifiers \ | ||
| -Wno-redundant-decls \ | ||
| -Wno-cast-align \ | ||
| -Wno-pointer-sign \ | ||
| -Wno-stringop-truncation \ | ||
| -Wno-cast-qual |
There was a problem hiding this comment.
@yue-fred-gao can you look at those warnings? i disabled those since *c files in vppxlate/*c developer produce a lot of warnings which are treated as errors by our convention, and for many of them, i don't know what was actual developer intention, and without any unittests provided on that i don't want to change any of this code
@yue-fred-gao will you be able to help to eliminate those warnings ?
also what is a purpose of vppxlate directory? is there any purpose of that on other repo? or this is specifically designed to for vpp in sairedis/buildimage ? is there specific requirement that this code needs to be in C and not cpp ?
There was a problem hiding this comment.
I created an issue (sonic-net/sonic-platform-vpp#149) to track this.
vppxlate is the vpp API adaptation layer. It is specifically for vpp. There is some history that I don't know but I guess vpp APIs are C code so C is used here.
Initial attempt