Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[syncd] Implement bulk set support #1422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stepanblyschak
Copy link
Contributor

No description provided.

Signed-off-by: Stepan Blyschak <[email protected]>
@DanielaMurin
Copy link

Regarding the tests added in bulk_object.rec, I didn't explicitly see SAI_OBJECT_TYPE_TUNNEL, SAI_OBJECT_TYPE_NEXT_HOP, or SAI_OBJECT_TYPE_NEXT_HOP_GROUP_MEMBER.
Are these object types included in the testing?

Thanks

{
SWSS_LOG_ERROR("bulkSet api is not implemented or not supported, object_type = %s",
sai_serialize_object_type(objectType).c_str());
return status;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return not needed here

@kcudnik
Copy link
Collaborator

kcudnik commented Oct 2, 2024

please satisfy code coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants