Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[submodule] Update SAI submodule to v1.13 #1285

Closed
wants to merge 8 commits into from

Conversation

kcudnik
Copy link
Collaborator

@kcudnik kcudnik commented Sep 2, 2023

Add needed changes and new files required by new SAI version

@kcudnik
Copy link
Collaborator Author

kcudnik commented Sep 2, 2023

O cherrypicked changes from #1255 to compensate for unittests, since SAI headers changes tunnel conditions and unittsts mus be updated

@kcudnik
Copy link
Collaborator Author

kcudnik commented Sep 3, 2023

buildswss amd64 seems to be not related to this change, since test crashes on neighbors, and this code don't touch neighbors at all, im making pure test on dummy commit just to see if it will compile #1286, sinc at this PR the swss failed to compile 3 times on the same error

@kcudnik
Copy link
Collaborator Author

kcudnik commented Sep 3, 2023

dummy build is passing, not sure how my change influences the unittests in swss, will try to investigate locally

@kcudnik
Copy link
Collaborator Author

kcudnik commented Sep 3, 2023

@stepanblyschak can you point me what could be the reason this fails ?

PASS: tests_response_publisher
../../config/test-driver: line 109:  8929 Aborted                 (core dumped) "$@" > $log_file 2>&1

i saw you worked on this on swss repo sonic-net/sonic-swss@4df5cab

and this fails, and i can't figure out direct correlation between my change and why this test fails, im just adding new api here

actually i noticed that "tests" are failing, should be "PASS: tests" but got core dumped

@kcudnik
Copy link
Collaborator Author

kcudnik commented Sep 3, 2023

@theasianpianist can you help me with that ?

[----------] 14 tests from MuxRollbackTest
[ RUN      ] MuxRollbackTest.StandbyToActiveNeighborAlreadyExists
FAIL tests (exit status: 134)

not sure how my change is related to this test, you worked on that sonic-net/sonic-swss@bc4062b12, but i don't see any correlation to my changes, i'm adding just new api support, nothing related to neighbor yet test somehow fail

@kcudnik
Copy link
Collaborator Author

kcudnik commented Sep 4, 2023

swss failure related to newer SAI:

Sep  4 13:00:34 713a148e1b79 tests: :- addDecapTunnel: Create overlay loopback router interface oid:600000003
Sep  4 13:00:34 713a148e1b79 tests: :- meta_generic_validation_create: SAI_TUNNEL_TERM_TABLE_ENTRY_ATTR_SRC_IP:SAI_ATTR_VALUE_TYPE_IP_ADDRESS attribute is conditional and is mandatory but not passed in attr list
Sep  4 13:00:34 713a148e1b79 tests: :- addDecapTunnelTermEntries: Failed to create tunnel entry table for ip: 2.2.2.2
Sep  4 13:00:34 713a148e1b79 tests: :- handleSaiCreateStatus: Encountered failure in create operation, exiting orchagent, SAI API: SAI_API_TUNNEL, status: SAI_STATUS_MANDATORY_ATTRIBUTE_MISSING
Sep  4 13:00:34 713a148e1b79 tests: :- meta_unittests_allow_readonly_set_once: unittests are not enabled
Sep  4 13:00:34 713a148e1b79 tests: :- handleSaiFailure: Failed to take sai failure dump -1

because of #1255, new attribute is required and metadata is catching this error

there is no way to solve that, one of the repos needs to be first checked in with failed state, then they both will pass, of course swss repo needs to be adapted to new SAI headers

@kcudnik
Copy link
Collaborator Author

kcudnik commented Sep 5, 2023

needs this sonic-net/sonic-swss#2894 to pass tests

@kcudnik
Copy link
Collaborator Author

kcudnik commented Sep 12, 2023

test errors not related to PR, @prsunny can you take a look seems like flacky tests are failing

@kcudnik
Copy link
Collaborator Author

kcudnik commented Sep 18, 2023

moved to another new PR

@kcudnik kcudnik closed this Sep 18, 2023
@kcudnik kcudnik deleted the v13 branch September 20, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant