-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[submodule] Update SAI submodule to v1.13 #1285
Conversation
O cherrypicked changes from #1255 to compensate for unittests, since SAI headers changes tunnel conditions and unittsts mus be updated |
buildswss amd64 seems to be not related to this change, since test crashes on neighbors, and this code don't touch neighbors at all, im making pure test on dummy commit just to see if it will compile #1286, sinc at this PR the swss failed to compile 3 times on the same error |
dummy build is passing, not sure how my change influences the unittests in swss, will try to investigate locally |
@stepanblyschak can you point me what could be the reason this fails ?
i saw you worked on this on swss repo sonic-net/sonic-swss@4df5cab and this fails, and i can't figure out direct correlation between my change and why this test fails, im just adding new api here actually i noticed that "tests" are failing, should be "PASS: tests" but got core dumped |
@theasianpianist can you help me with that ?
not sure how my change is related to this test, you worked on that sonic-net/sonic-swss@bc4062b12, but i don't see any correlation to my changes, i'm adding just new api support, nothing related to neighbor yet test somehow fail |
swss failure related to newer SAI:
because of #1255, new attribute is required and metadata is catching this error there is no way to solve that, one of the repos needs to be first checked in with failed state, then they both will pass, of course swss repo needs to be adapted to new SAI headers |
needs this sonic-net/sonic-swss#2894 to pass tests |
Add needed changes and new files required by new SAI version
test errors not related to PR, @prsunny can you take a look seems like flacky tests are failing |
moved to another new PR |
Add needed changes and new files required by new SAI version