Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure new binaries replace existing binaries in docker-sonic-vs #1269

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Make sure new binaries replace existing binaries in docker-sonic-vs #1269

merged 1 commit into from
Jul 31, 2023

Commits on Jul 30, 2023

  1. Make sure new binaries replace existing binaries in docker-sonic-vs 

    PR sonic-net#1225 removed a step where existing deb packages were removed before
installing the new deb packages. The problem is that due to Docker's
change detection code, where it only checks the file size and the
modification timestamp, even if the file gets modified when installing a
newer debian package, the file size may remain the same, and the
modification timestamp will remain the same (since this is based on the
debian/changelog timestamp). This caused changed binaries to not
actually replace the existing binaries.

Fix this by re-adding the line that removed existing packages first.

Signed-off-by: Saikrishna Arcot <[email protected]>
    @saiarcot895
    saiarcot895 committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    6364bcb View commit details
    Browse the repository at this point in the history