-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vslib]: Temporaily map DPU switch type to NVDA_MBF2H536C #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcudnik
requested changes
Jul 1, 2023
lguohan
previously approved these changes
Jul 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to DPU_SIMU_2P
kcudnik
previously approved these changes
Jul 5, 2023
minor: line 93 should be updated as well. |
lguohan
previously approved these changes
Jul 5, 2023
prabhataravind
changed the title
Temporaily map NPU switch type to NVDA_MBF2H536C
Temporaily map DPU switch type to NVDA_MBF2H536C
Jul 5, 2023
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
NVDA_MBF2H536C HWSKU information is not yet available in sonic-buildimage master and therefore a fake NPU HWKSU is added to sonic-buildimage which is being mapped internally to NVDA_MBF2H536C. This will help to run and pass DASH specific vstests using NPU HWSKU. Signed-off-by: Prabhat Aravind <[email protected]>
* Use a specific name SAI_VALUE_VS_SWITCH_TYPE_DPU_SIMU_2P for 2-port DPU Signed-off-by: Prabhat Aravind <[email protected]>
* Add SAI_VALUE_VS_SWITCH_TYPE_NVDA_MBF2H536C and SAI_VALUE_VS_SWITCH_TYPE_DPU_SIMU_2P to the log message for known switch types Signed-off-by: Prabhat Aravind <[email protected]>
kcudnik
reviewed
Jul 6, 2023
* Added TODO to spot it easily Signed-off-by: Prabhat Aravind <[email protected]>
/azp run |
kcudnik
previously approved these changes
Jul 6, 2023
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
changed the title
Temporaily map DPU switch type to NVDA_MBF2H536C
[vslib]: Temporaily map DPU switch type to NVDA_MBF2H536C
Jul 7, 2023
Signed-off-by: Prabhat Aravind <[email protected]>
kcudnik
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVDA_MBF2H536C HWSKU information is not yet available in sonic-buildimage master and therefore a fake NPU HWKSU is added to sonic-buildimage which is being mapped internally to NVDA_MBF2H536C. This will help to run and pass DASH specific vstests using NPU HWSKU.
Error we are trying to address:
Jun 29 19:34:55.043704 a6a6a10ed28f ERR #syncd: :- parseSwitchType: unknown switch type: 'SAI_VS_SWITCH_TYPE_NPU', expected (SAI_VS_SWITCH_TYPE_BCM81724|SAI_VS_SWITCH_TYPE_BCM56850|SAI_VS_SWITCH_TYPE_BCM56971B0|SAI_VS_SWITCH_TYPE_MLNX2700)
Jun 29 19:34:55.043712 a6a6a10ed28f ERR #syncd: :- Syncd: FATAL: failed to sai_api_initialize: SAI_STATUS_FAILURE
Jun 29 19:34:55.180774 a6a6a10ed28f INFO #supervisord 2023-06-29 19:34:55,180 INFO exited: syncd (terminated by SIGABRT (core dumped); not expected)
Jun 29 19:34:56.182412 a6a6a10ed28f INFO #supervisord 2023-06-29 19:34:56,182 INFO gave up: syncd entered FATAL state, too many start retries too