Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vslib]: Temporaily map DPU switch type to NVDA_MBF2H536C #1259

Merged
merged 5 commits into from
Jul 10, 2023

Conversation

prabhataravind
Copy link
Contributor

@prabhataravind prabhataravind commented Jul 1, 2023

NVDA_MBF2H536C HWSKU information is not yet available in sonic-buildimage master and therefore a fake NPU HWKSU is added to sonic-buildimage which is being mapped internally to NVDA_MBF2H536C. This will help to run and pass DASH specific vstests using NPU HWSKU.

Error we are trying to address:

Jun 29 19:34:55.043704 a6a6a10ed28f ERR #syncd: :- parseSwitchType: unknown switch type: 'SAI_VS_SWITCH_TYPE_NPU', expected (SAI_VS_SWITCH_TYPE_BCM81724|SAI_VS_SWITCH_TYPE_BCM56850|SAI_VS_SWITCH_TYPE_BCM56971B0|SAI_VS_SWITCH_TYPE_MLNX2700)
Jun 29 19:34:55.043712 a6a6a10ed28f ERR #syncd: :- Syncd: FATAL: failed to sai_api_initialize: SAI_STATUS_FAILURE
Jun 29 19:34:55.180774 a6a6a10ed28f INFO #supervisord 2023-06-29 19:34:55,180 INFO exited: syncd (terminated by SIGABRT (core dumped); not expected)
Jun 29 19:34:56.182412 a6a6a10ed28f INFO #supervisord 2023-06-29 19:34:56,182 INFO gave up: syncd entered FATAL state, too many start retries too

vslib/SwitchConfig.cpp Outdated Show resolved Hide resolved
lguohan
lguohan previously approved these changes Jul 2, 2023
Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to DPU_SIMU_2P

kcudnik
kcudnik previously approved these changes Jul 5, 2023
@lguohan
Copy link
Contributor

lguohan commented Jul 5, 2023

minor: line 93 should be updated as well.

lguohan
lguohan previously approved these changes Jul 5, 2023
@prabhataravind prabhataravind marked this pull request as ready for review July 5, 2023 21:38
@prabhataravind prabhataravind changed the title Temporaily map NPU switch type to NVDA_MBF2H536C Temporaily map DPU switch type to NVDA_MBF2H536C Jul 5, 2023
@prabhataravind
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

NVDA_MBF2H536C HWSKU information is not yet available in sonic-buildimage master
and therefore a fake NPU HWKSU is added to sonic-buildimage which is being
mapped internally to NVDA_MBF2H536C. This will help to run and pass DASH
specific vstests using NPU HWSKU.

Signed-off-by: Prabhat Aravind <[email protected]>
 * Use a specific name SAI_VALUE_VS_SWITCH_TYPE_DPU_SIMU_2P for 2-port DPU

Signed-off-by: Prabhat Aravind <[email protected]>
    * Add SAI_VALUE_VS_SWITCH_TYPE_NVDA_MBF2H536C and SAI_VALUE_VS_SWITCH_TYPE_DPU_SIMU_2P
      to the log message for known switch types

Signed-off-by: Prabhat Aravind <[email protected]>
vslib/SwitchConfig.cpp Outdated Show resolved Hide resolved
 * Added TODO to spot it easily

Signed-off-by: Prabhat Aravind <[email protected]>
@kcudnik
Copy link
Collaborator

kcudnik commented Jul 6, 2023

/azp run

kcudnik
kcudnik previously approved these changes Jul 6, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prabhataravind
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prabhataravind prabhataravind changed the title Temporaily map DPU switch type to NVDA_MBF2H536C [vslib]: Temporaily map DPU switch type to NVDA_MBF2H536C Jul 7, 2023
@prabhataravind prabhataravind merged commit d6055a2 into sonic-net:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants