Reject incorrect CIDR routes #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
approved these changes
Sep 27, 2021
| @@ -1075,6 +1075,20 @@ func ConfigVrouterVrfIdRoutesPatch(w http.ResponseWriter, r *http.Request) { | |||
| defer local_pt.Delete() | |||
|
|
|||
| for _, r := range attr { | |||
|
|
|||
| ip, network, err := net.ParseCIDR(r.IPPrefix) | |||
There was a problem hiding this comment.
Change looks good to me. It is better to provide some comments above and an example on expectation for future clarity.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Sep 28, 2021
This was referenced Sep 28, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuring incorrect CIDR addresses as routes is not permitted in SONiC and this PR will reject such incorrect routes from being configured using RestAPI.
In a batch config, if one or more routes are incorrect, only those routes will be rejected while the correct routes will be configured and an appropriate return-code will be sent.
Fixes: #74