Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System ready] Report ready status to Sysmonitor daemon #481

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

fastiuk
Copy link

@fastiuk fastiuk commented Apr 28, 2024

depends-on: sonic-net/sonic-buildimage#18817

Description

This change implements pmon's ability to report it's readines to sysmonitor

Motivation and Context

The motivation is to report the readiness of all SFPs to sysmonitor and not just the startup of pmon

How Has This Been Tested?

  • Run NOS on the box
  • Make sure pmon reports good readiness state and you can see it in sysmonitor

Additional Information (Optional)

@prgeor
Copy link
Collaborator

prgeor commented Apr 30, 2024

@fastiuk please update the details in the PR:-

Description
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)`
``

sonic-xcvrd/xcvrd/xcvrd.py Outdated Show resolved Hide resolved
sonic-xcvrd/xcvrd/xcvrd.py Outdated Show resolved Hide resolved
@mihirpat1
Copy link
Contributor

@fastiuk Can you please elaborate more on what do you mean by reporting the readiness of all SFPs?
Is readiness classified as

  1. SfpStateUpdateTask has detected all SFPs present of the device?
  2. CmisManagerTask has performed CMIS initialization of all CMIS SFPs?
  3. XCVRD has spawned its child threads. In this case, readiness doesn't have any bearing on SFPs being detected or any child thread crashing while detecting or initializing the transceivers.

The above question is in reference to the below PR description
The motivation is to report the readiness of all SFPs to sysmonitor and not just the startup of pmon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants