-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for the issues uncovered by sonic-pcied unit tests #389
Conversation
- Lack of getKeys() impl in mock swsscommon table class in sonic-pcied - Fixed a 'set' bug in pcied that was uncovered by new code flows
@assrinivasan can you remove the mocked table from all the tests and instead use the mocked lib of swsscommon? Ex:https://github.com/sonic-net/sonic-platform-daemons/blob/master/sonic-pcied/tests/test_DaemonPcied.py#L285 |
Done in latest commit. |
/easycla |
…ic-net#389)" This reverts commit 76baca3.
* Fixes for the following issues: - Lack of getKeys() impl in mock swsscommon table class in sonic-pcied - Fixed a 'set' bug in pcied that was uncovered by new code flows * Removed mocked table instances per prgeor review comments
* Revert "Fixes for the issues uncovered by sonic-pcied unit tests (#389)" This reverts commit 76baca3. * Revert "Added PCIe transaction check for all peripherals on the bus (#331)" This reverts commit d73808c. * Fixes for the issues uncovered by sonic-pcied unit tests (#389) * Fixes for the following issues: - Lack of getKeys() impl in mock swsscommon table class in sonic-pcied - Fixed a 'set' bug in pcied that was uncovered by new code flows * Removed mocked table instances per prgeor review comments
* Revert "Fixes for the issues uncovered by sonic-pcied unit tests (sonic-net#389)" This reverts commit 76baca3. * Revert "Added PCIe transaction check for all peripherals on the bus (sonic-net#331)" This reverts commit d73808c. * Fixes for the issues uncovered by sonic-pcied unit tests (sonic-net#389) * Fixes for the following issues: - Lack of getKeys() impl in mock swsscommon table class in sonic-pcied - Fixed a 'set' bug in pcied that was uncovered by new code flows * Removed mocked table instances per prgeor review comments
@prgeor could we have ADO to support this cherry pick? |
* Fixes for the following issues: - Lack of getKeys() impl in mock swsscommon table class in sonic-pcied - Fixed a 'set' bug in pcied that was uncovered by new code flows * Removed mocked table instances per prgeor review comments
Description
Fixes for the following issues:
Motivation and Context
This PR fixes issues in pcied as well as mock implementations for unit tests that were uncovered by new code flows.
How Has This Been Tested?
Recreated the new code flow with the changes and ensured that all the tests passed without exceptions