Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[thermalctld] Refactor to allow for greater unit test coverage; Add more unit tests #157

Merged
merged 43 commits into from
Mar 18, 2021
Merged

[thermalctld] Refactor to allow for greater unit test coverage; Add more unit tests #157

merged 43 commits into from
Mar 18, 2021

Commits on Mar 18, 2021

  1. [thermalctld] Refactor to allow for greater unit test coverage

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    011b96b View commit details
    Browse the repository at this point in the history

  2. Increase pytest verbosity

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    b814e16 View commit details
    Browse the repository at this point in the history

  3. Refactor unit tests to align with source

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    126263c View commit details
    Browse the repository at this point in the history

  4. Add mocked swsscommon lib

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    2156279 View commit details
    Browse the repository at this point in the history

  5. Remove THERMALCTLD_UNIT_TESTING env var

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    5198692 View commit details
    Browse the repository at this point in the history

  6. Use pytest fixture for setup/teardown

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    7663fa0 View commit details
    Browse the repository at this point in the history

  7. Use call_count in favor of assert_called[_once]

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    082f3c0 View commit details
    Browse the repository at this point in the history

  8. Fix test bug and check both instances to ensure class var is correct

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    53fea67 View commit details
    Browse the repository at this point in the history

  9. [mock_platform] inherit from sonic_platform_base

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    a2df880 View commit details
    Browse the repository at this point in the history

  10. Update mock_platform.py

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    aca1580 View commit details
    Browse the repository at this point in the history

  11. Tests use new setters

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    e25363c View commit details
    Browse the repository at this point in the history

  12. Use parens instead of escaping newlines

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    02bc7ab View commit details
    Browse the repository at this point in the history

  13. Change 'absence' to 'absent', 'fault' to 'faulty' where applicable

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    b118e0e View commit details
    Browse the repository at this point in the history

  14. Add tests for signal handler

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    13ddb52 View commit details
    Browse the repository at this point in the history

  15. import sys

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    c72e31e View commit details
    Browse the repository at this point in the history

  16. Add MockThermalManager class to mock_platform.py

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    04eb5ef View commit details
    Browse the repository at this point in the history

  17. Replace 'deinit()' methods with actual destructors

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    f4a036a View commit details
    Browse the repository at this point in the history

  18. Replace 'takes' with 'took'

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    ff163a7 View commit details
    Browse the repository at this point in the history

  19. Use more modern method of initializing base class

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    ba8069e View commit details
    Browse the repository at this point in the history

  20. Go back to deinitializer methods 

    There appears to be a circular dependency which prevents the
ThermalControlDaemon object in main from being garbage collected when we
add a custom destructor
    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    8b480d5 View commit details
    Browse the repository at this point in the history

  21. become -> became

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    487278f View commit details
    Browse the repository at this point in the history

  22. Add tests for ThermalControlDaemon.run() and main()

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    873827e View commit details
    Browse the repository at this point in the history

  23. Add test_temperupdater_deinit

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    79151bf View commit details
    Browse the repository at this point in the history

  24. Grammar tweaks, pluralize message dynamically

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    4d5f6ea View commit details
    Browse the repository at this point in the history

  25. Temp test

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    0321f2a View commit details
    Browse the repository at this point in the history

  26. Remove unnecessary periods from log messages to align all

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    b9ae023 View commit details
    Browse the repository at this point in the history

  27. Add test case for TemperatureStatus.set_temperature when temp is not … 

    …available
    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    2e8409f View commit details
    Browse the repository at this point in the history

  28. Add TestFanStatus class and test_check_speed_value_available method

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    dd14af4 View commit details
    Browse the repository at this point in the history

  29. Add test case for try_get()

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    c4de3fc View commit details
    Browse the repository at this point in the history

  30. Add TestFanUpdater class and test_deinit() method

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    720b8b8 View commit details
    Browse the repository at this point in the history

  31. Add test case for FanUpdater._refresh_fan_drawer_status

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    5315205 View commit details
    Browse the repository at this point in the history

  32. Fix grammar, add details to log messages

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    f019f50 View commit details
    Browse the repository at this point in the history

  33. Add test case for update_entity_info()

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    4f5db27 View commit details
    Browse the repository at this point in the history

  34. Add test_set_fan_led_exception

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    006cbc9 View commit details
    Browse the repository at this point in the history

  35. [ThermalMonitor] Break loop logic out into separate function for unit… 

    … testing purposes
    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    637822b View commit details
    Browse the repository at this point in the history

  36. Add TestThermalMonitor class and test_main() method

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    74447f7 View commit details
    Browse the repository at this point in the history

  37. [TestFanUpdater] Add PSU fan test

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    04f0838 View commit details
    Browse the repository at this point in the history

  38. Add TestTemperatureUpdater class and test_update_psu_thermals() metho… 

    …d; Reorganize
    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    41a3996 View commit details
    Browse the repository at this point in the history

  39. Remove 'repr()' around exception to make log message identical betwee… 

    …n Python 2 and 3
    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    89a797f View commit details
    Browse the repository at this point in the history

  40. Check for more log messages

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    1c2c631 View commit details
    Browse the repository at this point in the history

  41. Add MockSfpBase class to mock_platform.py

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    a5af749 View commit details
    Browse the repository at this point in the history

  42. Add test_update_sfp_thermals

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    8e28094 View commit details
    Browse the repository at this point in the history

  43. Switch back to printing 'repr(e)'

    @jleveque
    jleveque committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    3104fdf View commit details
    Browse the repository at this point in the history