-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[thermalctld] [psud] [chassisd] Fix crash with undefined environment variable #120
Conversation
Signed-off-by: Petro Bratash <[email protected]>
Signed-off-by: Petro Bratash <[email protected]>
@akokhan, please review |
@jleveque CI failure when update submodule: sonic-net/sonic-buildimage#5945
|
@bratashX: You should be able to follow the instructions for sonic-utilities, but reference the thermalctld package instead: https://github.com/Azure/sonic-utilities/blob/master/README.md#setting-up-a-buildtest-environment. |
@jleveque, thanks |
…variable (#120) When `PSUD_UNIT_TESTING` and `THERMALCTLD_UNIT_TESTING` variables don`t set we have the next problems: ``` psud Traceback (most recent call last): psud File "/usr/local/bin/psud", line 21, in <module> psud if os.environ["PSUD_UNIT_TESTING"] == "1": psud File "/usr/lib/python2.7/UserDict.py", line 40, in __getitem__ psud raise KeyError(key) psud KeyError: 'PSUD_UNIT_TESTING' ``` ``` thermalctld Traceback (most recent call last): thermalctld File "/usr/local/bin/thermalctld", line 19, in <module> thermalctld if os.environ["THERMALCTLD_UNIT_TESTING"] == "1": thermalctld File "/usr/lib/python2.7/UserDict.py", line 40, in __getitem__ thermalctld raise KeyError(key) thermalctld KeyError: 'THERMALCTLD_UNIT_TESTING' ``` Also fixed the same issue in `chassisd`. Signed-off-by: Petro Bratash <[email protected]>
Update dependencies in setup.py to align with current needs. This allows for implicit installation of dependencies at build and run time, and prevents the need to explicitly install these packages.
When
PSUD_UNIT_TESTING
andTHERMALCTLD_UNIT_TESTING
variables don`t set we have the next problems:Also fixed the same issue in
chassisd
.Signed-off-by: Petro Bratash [email protected]