[action] [PR:490] [CMIS] Add lane_mask parameter to set_loopback_mode() to enable setti… (#490) #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonic-net#490) * [CMIS] Add lane_mask parameter to set_loopback_mode() to enable setting loopback mode for individual lanes rather than the entire physical port Signed-off-by: xinyu <[email protected]> * [CMIS] Add options to individually clear host/media, input/output loopback modes and log errors for all rejection cases Signed-off-by: xinyu <[email protected]> * [CMIS] Reject the loopback mode request if simultaneous host and media loopback is not supported or per-lane loopback is not supported Signed-off-by: xinyu <[email protected]> * [CMIS] Log errors for all set loopback mode rejection cases Signed-off-by: xinyu <[email protected]> * [CMIS] Improve readability by using individual functions for setting host, media, input, and output loopback modes Signed-off-by: xinyu <[email protected]> * [CMIS] Add an enable parameter to eliminate the need for loopback modes with the -none suffix Signed-off-by: xinyu <[email protected]> --------- Signed-off-by: xinyu <[email protected]>
|
Original PR: #490 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xinyu [email protected]
Signed-off-by: xinyu [email protected]
Signed-off-by: xinyu [email protected]
Signed-off-by: xinyu [email protected]
Signed-off-by: xinyu [email protected]
Signed-off-by: xinyu [email protected]
Signed-off-by: xinyu [email protected]