[ssd_generic] Add support Transcend ssd-health. #436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide SONiC cli command of ssd-health to support SSD vendor: Transcend.
ex:
show platform ssdhealth [--vendor]
or
ssdutil [--vendor]
Motivation and Context
[Why to do]:
We use Transcend' SSD model name as below in our DUT:
And found the issue by use defaut parsing method:
smartctl {} -a
The result as below:
Wrong heath percentage, wrong temperature:
[How to solved]:
The issue in not mean
smartctl {} -a
read wrong info, and the root cause is happening by parsing wrong format(field) (using generic method).We can get the correct info via another tool==> Transcend tool:
scopepro
ex:
For this reason, this PR for support Transcend SSD by using tool:
scopepro
and add specific transcend_parsing method.Via transcend_parsing method, we can get correct info,
ex:
How Has This Been Tested?
I've been verify the test by adding transcend info at
tests/ssd_generic_test.py
for self-test.By using the command on sonic-buildimage : make sure
sonic_platform_common-1.0-py3-none-any.whl
can be constructed successfully (meaning including self-test).
Additional Information (Optional)
If this PR been merged in the future, I will add Transcend tool:
scopepro
into sonic-buildimage for using.