Comment out tx power validation check and program the passed value #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeprom write function. Signed-off-by: Abhishek Dosi <[email protected]>
prgeor
reviewed
Jul 27, 2023
| if tx_power > max_prog_tx_output_power or tx_power < min_prog_tx_output_power: | ||
| raise ValueError('Provisioned TX power out of range. Max: %.1f; Min: %.1f dBm.' | ||
| %(max_prog_tx_output_power, min_prog_tx_output_power)) | ||
| #Comment out validation for now. |
There was a problem hiding this comment.
@abdosi can you remove the code itself?
gechiang
approved these changes
Jul 27, 2023
prgeor
approved these changes
Jul 28, 2023
|
MSFT ADO: 24669442 |
|
@yxieca , @StormLiangMS , can you help cherry-pick this bug fix to the needed branches accordingly? |
StormLiangMS
pushed a commit
that referenced
this pull request
Aug 6, 2023
) * Comment out power validation check and program the passed value to the eeprom write function. Signed-off-by: Abhishek Dosi <[email protected]> * Update c_cmis.py --------- Signed-off-by: Abhishek Dosi <[email protected]>
|
@yxieca, please let us know if this can be cherry-picked cleanly into 202205. If not, we will have to raise a 202205 specific PR for it... |
yxieca
pushed a commit
that referenced
this pull request
Aug 14, 2023
) * Comment out power validation check and program the passed value to the eeprom write function. Signed-off-by: Abhishek Dosi <[email protected]> * Update c_cmis.py --------- Signed-off-by: Abhishek Dosi <[email protected]>
|
@yxieca , can you also approve this for 202211 so we can mark the ADO as complete. Thanks! |
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
* Fixes for the following issues: - Lack of getKeys() impl in mock swsscommon table class in sonic-pcied - Fixed a 'set' bug in pcied that was uncovered by new code flows * Removed mocked table instances per prgeor review comments
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
* Revert "Fixes for the issues uncovered by sonic-pcied unit tests (sonic-net#389)" This reverts commit 76baca3. * Revert "Added PCIe transaction check for all peripherals on the bus (sonic-net#331)" This reverts commit d73808c. * Fixes for the issues uncovered by sonic-pcied unit tests (sonic-net#389) * Fixes for the following issues: - Lack of getKeys() impl in mock swsscommon table class in sonic-pcied - Fixed a 'set' bug in pcied that was uncovered by new code flows * Removed mocked table instances per prgeor review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Comment out tx power validation check and program the passed value to eeprom write function
MSFT ADO: 17893499
Why I did:
For some of our 400G ZR optics calibrated value of tx power is not in min and max range of advertised value which causes xcvrd to crash and then links do not come up . This fix is short term solution to skip the validation check.
How I verify:
After this change not seeing xcvrd crash.