Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic_ssd] Nokia-7215: "show platform ssdhealth" not showing health percent #279

Merged
merged 3 commits into from
May 11, 2022

Conversation

bill-nokia
Copy link
Contributor

@bill-nokia bill-nokia commented Apr 19, 2022

Description

The command is not showing the correct value for ssd health.

admin@sonic:~$ show platform ssdhealth
Device Model : M.2 (S42) 3IE4
Health       : N/A
Temperature  : 25C

Motivation and Context

SSD health percentage not displayed on Nokia-7215 platform.

How Has This Been Tested?

"show platform ssdhealth" cli command
Output after fix:

admin@sonic:~$ show platform ssdhealth 
Device Model : M.2 (S42) 3IE4
Health       : 100%
Temperature  : 25C

Additional Information (Optional)

…percent

The command is not showing the correct value for ssd health.

admin@sonic:~$ show platform ssdhealth
Device Model : M.2 (S42) 3IE4
Health       : N/A
Temperature  : 25C
@ghost
Copy link

ghost commented Apr 19, 2022

CLA assistant check
All CLA requirements met.

@carl-nokia
Copy link

@sujinmkang hoping to get this in for future release, multiple merges required including 202012

@Blueve
Copy link

Blueve commented May 5, 2022

@carl-nokia do you want to backport this change to 202012 and 202111 only?

@carl-nokia
Copy link

@Blueve --yes - please backport this change to 202012 and 202111

@Blueve
Copy link

Blueve commented May 9, 2022

Hi @carl-nokia , can you address above comments?

@bill-nokia
Copy link
Contributor Author

@Blueve @sujinmkang I added a commit on May 5th to address the comments above. Let me know if it needs to be updated

@sujinmkang sujinmkang changed the title [sonic_ssd] Nokia-7215: "show platform ssdhealth" not showing health … [sonic_ssd] Nokia-7215: "show platform ssdhealth" not showing health percent May 11, 2022
@sujinmkang sujinmkang merged commit b043372 into sonic-net:master May 11, 2022
@bill-nokia bill-nokia deleted the ssd-health-fix branch May 11, 2022 13:37
judyjoseph pushed a commit that referenced this pull request May 16, 2022
…percent (#279)

Description
The command is not showing the correct value for ssd health.

admin@sonic:~$ show platform ssdhealth
Device Model : M.2 (S42) 3IE4
Health       : N/A
Temperature  : 25C
Motivation and Context
SSD health percentage not displayed on Nokia-7215 platform.

How Has This Been Tested?
"show platform ssdhealth" cli command
Output after fix:

admin@sonic:~$ show platform ssdhealth 
Device Model : M.2 (S42) 3IE4
Health       : 100%
Temperature  : 25C
qiluo-msft pushed a commit that referenced this pull request May 16, 2022
…percent (#279)

Description
The command is not showing the correct value for ssd health.

admin@sonic:~$ show platform ssdhealth
Device Model : M.2 (S42) 3IE4
Health       : N/A
Temperature  : 25C
Motivation and Context
SSD health percentage not displayed on Nokia-7215 platform.

How Has This Been Tested?
"show platform ssdhealth" cli command
Output after fix:

admin@sonic:~$ show platform ssdhealth 
Device Model : M.2 (S42) 3IE4
Health       : 100%
Temperature  : 25C
itamar-talmon pushed a commit to itamar-talmon/sonic-platform-common that referenced this pull request Jan 12, 2023
…percent (sonic-net#279)

Description
The command is not showing the correct value for ssd health.

admin@sonic:~$ show platform ssdhealth
Device Model : M.2 (S42) 3IE4
Health       : N/A
Temperature  : 25C
Motivation and Context
SSD health percentage not displayed on Nokia-7215 platform.

How Has This Been Tested?
"show platform ssdhealth" cli command
Output after fix:

admin@sonic:~$ show platform ssdhealth 
Device Model : M.2 (S42) 3IE4
Health       : 100%
Temperature  : 25C
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
This PR provides a capability to sonic-utilities CLI to enable/disable telemetry for ycabled.
Basically there is a periodic loop for ycabled which posts telemetry data for that configured interval of time(currently 60 sec). This PR diables this data posting, and does not call platform API calls for ycable.
This PR is required for the initiative of getting some failover/switchover not get interfered because of sonic-telemetry API calls.
The CLI for enabling/disabling telemetry is
config muxcable telemetry enable/disable

Description
Motivation and Context
How Has This Been Tested?
UT and deploying changes on Arista testbed

Signed-off-by: vaibhav-dahiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants