Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new reboot-cause to cover more scenarios #277

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Apr 11, 2022

Signed-off-by: Kebo Liu [email protected]

Description

Add some new reboot causes to cover followinging scenarios:

  1. BIOS - In case the BIOS upgrade process ended with failure and cause the switch to reset.
  2. CPU - Reset is initiated by SW on the CPU. it could be that SW encountered some catastrophic situation like a memory leak, eventually, the kernel reset the whole switch.
  3. Push button - Reset by pushing the reset button
  4. Reset from ASIC - Reset which is caused by ASIC.

Motivation and Context

Add more reboot causes to cover more scenarios.

How Has This Been Tested?

UT is added with the code change.
run community reboot test to see the reboot cause checker can pass.

Additional Information (Optional)

@liat-grozovik liat-grozovik merged commit b70e759 into sonic-net:master Apr 11, 2022
@keboliu keboliu deleted the reboot_cause branch April 12, 2022 00:16
liat-grozovik pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Apr 18, 2022
- Why I did it
Implement newly added reboot causes in PR sonic-net/sonic-platform-common#277

- How I did it
Map the reboot cause sysfs to the newly added reboot causes.

- How to verify it
manual test, check whether the reboot cause is correct after rebooting the switch in various ways.
run the community reboot test to see whether the reboot cause checker is passing.

Signed-off-by: Kebo Liu <[email protected]>
liat-grozovik pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Dec 5, 2022
Add new script to cover following reboot cause scenarios:

BIOS - In case the BIOS upgrade process ended with failure and cause the switch to reset.
CPU - Reset is initiated by SW on the CPU. it could be that SW encountered some catastrophic situation like a memory leak, eventually, the kernel reset the whole switch.
Reset from ASIC - Reset which is caused by ASIC.

- What is the motivation for this PR?
Add test for sonic-net/sonic-platform-common#277

- How did you do it?

- How did you verify/test it?
Add test script for enhance reboot cause

- Any platform specific information?
Mellanox platforms, except for SPC1 and SIMX

- Supported testbed topology if it's a new test case?
Any topology
itamar-talmon pushed a commit to itamar-talmon/sonic-platform-common that referenced this pull request Jan 12, 2023
- Description
Add some new reboot causes to cover followinging scenarios:
BIOS - In case the BIOS upgrade process ended with failure and cause the switch to reset.
CPU - Reset is initiated by SW on the CPU. it could be that SW encountered some catastrophic situation like a memory leak, eventually, the kernel reset the whole switch.
Push button - Reset by pushing the reset button
Reset from ASIC - Reset which is caused by ASIC.
Motivation and Context
Add more reboot causes to cover more scenarios.

- How Has This Been Tested?
UT is added with the code change.
Run community reboot test to see the reboot cause checker can pass.

Signed-off-by: Kebo Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants