Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more changes needed for SNMP docker upgrade to stretch build #26

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

samaity
Copy link
Contributor

@samaity samaity commented Apr 3, 2019

Signed-off-by: Sangita Maity [email protected]

  • What I did

I was getting lots of import error during SNMP docker upgrade to stretch build. Made changes accordingly to fix those issues. May be python compatibility issue as by default it is using python3 and there's no exceptions module in python3

  • How I did it
    Made it compatible with python3 whenever required.

  • How to verify it
    Use this PR with snmp docker upgrade PR in sonic-buildimage.

@samaity
Copy link
Contributor Author

samaity commented Apr 3, 2019

@jleveque could you kindly review it? I need this PR for snmp docker stretch upgrade work in sonic-buildimage.

@jleveque jleveque merged commit 92b54b1 into sonic-net:master Apr 3, 2019
@samaity samaity deleted the snmp_stretch_fork branch April 17, 2019 18:47
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants